From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755763AbcARQEc (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 Jan 2016 11:04:32 -0500
Received: from mail1.bemta8.messagelabs.com ([216.82.243.203]:23129 "EHLO
	mail1.bemta8.messagelabs.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1755555AbcARQEa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 Jan 2016 11:04:30 -0500
X-Greylist: delayed 393 seconds by postgrey-1.27 at vger.kernel.org; Mon, 18 Jan 2016 11:04:29 EST
X-Env-Sender: Marc_Gonzalez@sigmadesigns.com
X-Msg-Ref: server-16.tower-94.messagelabs.com!1453132673!21038619!1
X-Originating-IP: [195.215.56.170]
X-StarScan-Received: 
X-StarScan-Version: 7.35.1; banners=-,-,-
X-VirusChecked: Checked
Subject: Re: [RFC PATCH v2] irqchip: Add support for Tango interrupt
 controller
To: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>,
        Marc Zyngier <marc.zyngier@arm.com>
CC: LKML <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Mans Rullgard <mans@mansr.com>, Sebastian Frias <sf84@laposte.net>
References: <569CE0F2.1060507@sigmadesigns.com>
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Message-ID: <569D0B80.1010908@sigmadesigns.com>
Date: Mon, 18 Jan 2016 16:57:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101
 Firefox/42.0 SeaMonkey/2.39
MIME-Version: 1.0
In-Reply-To: <569CE0F2.1060507@sigmadesigns.com>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.27.0.114]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 18/01/2016 13:56, Marc Gonzalez wrote:

> For the arch/arm/mach-tango port, I'm using this driver written
> by Mans. Version 1 of the patch was submitted two months ago:
> http://thread.gmane.org/gmane.linux.kernel/2089471
> 
> I've tried to address Marc Zyngier's remarks.

And my patch is incomplete, v3 coming right up.

drivers/irqchip/irq-tango.c: In function 'tangox_irq_init':
drivers/irqchip/irq-tango.c:183:6: warning: unused variable 'i' [-Wunused-variable]
  int i;
      ^
drivers/irqchip/irq-tango.c: In function 'tangox_of_irq_init':
drivers/irqchip/irq-tango.c:200:6: warning: 'name' may be used uninitialized in this function [-Wmaybe-uninitialized]
  err = irq_alloc_domain_generic_chips(dom, 32, 2, name, handle_level_irq,
      ^
drivers/irqchip/irq-tango.c:179:14: note: 'name' was declared here
  const char *name;
              ^

Regards.