From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754129AbcASNGV (ORCPT ); Tue, 19 Jan 2016 08:06:21 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:58171 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbcASNGP (ORCPT ); Tue, 19 Jan 2016 08:06:15 -0500 Subject: Re: [PATCH v2 1/1] watchdog: sp805: ping fails to abort wdt reset To: Sandeep Tripathy , wim@iguana.be References: <1453194889-27860-1-git-send-email-tripathy@broadcom.com> Cc: viresh.kumar@linaro.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com From: Guenter Roeck Message-ID: <569E34C4.5020005@roeck-us.net> Date: Tue, 19 Jan 2016 05:06:12 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1453194889-27860-1-git-send-email-tripathy@broadcom.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2016 01:14 AM, Sandeep Tripathy wrote: > sp805 wdt asserts interrupt for the first expiry and > reloads the counter. If wdt interrupt is set and count > reaches zero then wdt reset event is generated. To get > wdt reset at 't' timeout the driver loads wdt counter > with 't/2'. A ping before time 't' *should* prevent > wdt reset. Currently if ping is done after 't/2' then > wdt interrupt condition gets set. On the next countdown > of loadval wdt reset event occurs eventhough wdt was > reloaded before the set timeout 't'. > > This patch clears the interrupt condition on ping. > > Signed-off-by: Sandeep Tripathy Reviewed-by: Guenter Roeck > --- > drivers/watchdog/sp805_wdt.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/watchdog/sp805_wdt.c b/drivers/watchdog/sp805_wdt.c > index 01d8162..e7a715e 100644 > --- a/drivers/watchdog/sp805_wdt.c > +++ b/drivers/watchdog/sp805_wdt.c > @@ -139,12 +139,11 @@ static int wdt_config(struct watchdog_device *wdd, bool ping) > > writel_relaxed(UNLOCK, wdt->base + WDTLOCK); > writel_relaxed(wdt->load_val, wdt->base + WDTLOAD); > + writel_relaxed(INT_MASK, wdt->base + WDTINTCLR); > > - if (!ping) { > - writel_relaxed(INT_MASK, wdt->base + WDTINTCLR); > + if (!ping) > writel_relaxed(INT_ENABLE | RESET_ENABLE, wdt->base + > WDTCONTROL); > - } > > writel_relaxed(LOCK, wdt->base + WDTLOCK); > >