From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755229AbcASNhf (ORCPT ); Tue, 19 Jan 2016 08:37:35 -0500 Received: from foss.arm.com ([217.140.101.70]:39652 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753831AbcASNhZ (ORCPT ); Tue, 19 Jan 2016 08:37:25 -0500 Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes To: Zhong Kaihua , robh+dt@kernel.org References: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com> Cc: pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, catalin.marinas@arm.com, will.deacon@arm.com, xuyiping@hisilicon.com, xuwei5@hisilicon.com, bintian.wang@huawei.com, haojian.zhuang@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, puck.chen@hisilicon.com, Sudeep Holla , w.f@huawei.com, dan.zhao@hisilicon.com, kong.kongxinwei@hisilicon.com From: Sudeep Holla Organization: ARM Message-ID: <569E3C0F.3040603@arm.com> Date: Tue, 19 Jan 2016 13:37:19 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/01/16 10:51, Zhong Kaihua wrote: > arm64: dts: Add Hi6220 gpio configuration nodes > > Signed-off-by: Zhong Kaihua > Kong Xinwei > > Acked-by: Rob Herring > --- > .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 + > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + > arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++ > arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++ > 4 files changed, 890 insertions(+) > create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt > create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi > > diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt > new file mode 100644 > index 0000000..a9cbf21 > --- /dev/null > +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt > @@ -0,0 +1,23 @@ > +Hisilicon Hi6220 GPIO controller bindings > + > +Required properties: > + - compatible: "arm,pl061","arm,primecell" > + - gpio-controller: Marks the device node as a GPIO controller. > + - #gpio-cells: Should be 2. See gpio.txt in this directory for a > + description of the cells format. > + - interrupt-controller: Mark the device node as an interrupt controller > + Why do you need extra binding document here as the compatible is same as [1] ? You can extend that if required and add example there IMO. -- Regards, Sudeep [1] Documentation/devicetree/bindings/gpio/pl061-gpio.txt