From: Vlastimil Babka <vbabka@suse.cz>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <ying.huang@linux.intel.com>,
Ebru Akagunduz <ebru.akagunduz@gmail.com>,
lkp@01.org, LKML <linux-kernel@vger.kernel.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
Michal Hocko <mhocko@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>, Xie XiuQi <xiexiuqi@huawei.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrea Arcangeli <aarcange@redhat.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Rik van Riel <riel@redhat.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer dereference at (null)
Date: Wed, 20 Jan 2016 00:07:46 +0100 [thread overview]
Message-ID: <569EC1C2.1060906@suse.cz> (raw)
In-Reply-To: <20160119224536.GA2262@uranus>
On 01/19/2016 11:45 PM, Cyrill Gorcunov wrote:
> On Tue, Jan 19, 2016 at 02:30:45PM -0800, David Rientjes wrote:
>> On Tue, 19 Jan 2016, Cyrill Gorcunov wrote:
>>
>> > Seems it should be something like that (untested at moment, please
>> > take a look).
>> > ---
>> > From: Cyrill Gorcunov <gorcunov@openvz.org>
>> > Subject: [PATCH] mm: Fix tracepoint for scanning pages
>> >
>> > The page might be NULL so use page_to_pfn in conditional call.
>> >
>> > Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
>>
>> I think this is obviously correct, so
>>
>> Acked-by: David Rientjes <rientjes@google.com>
>
> Thank you. I've compile tested it, but didn't run.
This has been in mmotm since november:
http://ozlabs.org/~akpm/mmotm/broken-out/mm-fix-kernel-crash-in-khugepaged-thread.patch
Although your patch does use -1UL instead of -1 (AFAICS the only difference, but
it's too late here), which Steven Rostedt suggested, so it's probably better.
next prev parent reply other threads:[~2016-01-19 23:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <8737tue3mn.fsf@yhuang-dev.intel.com>
2016-01-19 8:02 ` [lkp] [mm] 7d2eba0557: BUG: unable to handle kernel NULL pointer dereference at (null) Cyrill Gorcunov
2016-01-19 22:30 ` David Rientjes
2016-01-19 22:45 ` Cyrill Gorcunov
2016-01-19 23:07 ` Vlastimil Babka [this message]
2016-01-20 7:26 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=569EC1C2.1060906@suse.cz \
--to=vbabka@suse.cz \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=ebru.akagunduz@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@01.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
--cc=xiexiuqi@huawei.com \
--cc=ying.huang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).