From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757770AbcASXmm (ORCPT ); Tue, 19 Jan 2016 18:42:42 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:43834 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756908AbcASXme (ORCPT ); Tue, 19 Jan 2016 18:42:34 -0500 X-AuditID: cbfec7f5-f79b16d000005389-b7-569ec9e7aeec Subject: Re: [PATCH v2 3/3] clk: s2mps11: remove redundant code To: Andi Shyti , linux-samsung-soc@vger.kernel.org References: <1453193552-4761-1-git-send-email-andi.shyti@samsung.com> <1453193552-4761-4-git-send-email-andi.shyti@samsung.com> Cc: Sangbeom Kim , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar From: Krzysztof Kozlowski Message-id: <569EC9E6.1020801@samsung.com> Date: Wed, 20 Jan 2016 08:42:30 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453193552-4761-4-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsVy+t/xK7rPT84LM9j8R9Zi+5FnrBaLfzxn snj9wtDiY889VovLu+awWcw4v4/J4uIpV4uLK74wWfw4081iMfd3I6sDl8f7G63sHpf7epk8 ri/5xOyxc9Zddo++LasYPT5vkgtgi+KySUnNySxLLdK3S+DKeLZ5K2PBVMWKpyceMDYwXpfq YuTkkBAwkTj+5AwbhC0mceHeeiCbi0NIYCmjxIetJ5m6GDmAnKeMEj3uIDXCAvYSnV+XsYLY IgJeElMfnmCEqG9klJj06xILiMMs0MYkcfL9dBaQKjYBY4nNy5eAbeAV0JL4vmkOM4jNIqAq sa+5D2ySqECExOHOLnaIGkGJH5PvsYAs5hRwk+heEQJiMgvoSdy/qAVSwSwgL7F5zVvmCYwC s5A0zEKomoWkagEj8ypG0dTS5ILipPRcI73ixNzi0rx0veT83E2MkCj4uoNx6TGrQ4wCHIxK PLyMzfPChFgTy4orcw8xSnAwK4nwnt0CFOJNSaysSi3Kjy8qzUktPsQozcGiJM47c9f7ECGB 9MSS1OzU1ILUIpgsEwenVAPj/vlnsy5t6O7Zrpha6Xbj1p53XFuvajtMyLt10a86ruU749rv h88UK92SXm5dv+Ic70q7nyfr/R5+OipTeNmTxW92gnsr14sbbPvNp17zCqjcntx6SuINp5fe 8xMGDy1jDVwTlunPvbJdgbGh3SnA5u6UvWs/C7vsPLt1b+El40k7Mi9MmDEnSomlOCPRUIu5 qDgRAHh1yeV+AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.01.2016 17:52, Andi Shyti wrote: > This patch performs some code removal as it uses some variables > for temporary use. Three changes: > > * In the probe function the s2mps11_clk pointer is used only to > iterate through the s2mps11_clks. The naming itself brings > confusion and the readability is not improved. > > * the s2mps11_name() define resolves the name of the a given > device. As it is used only once, we can expand it where it's used > and remove the defininition. > > * The **clk_table variable is declared as a static variable and > used to reference some allocated memory, it's then assigned to > the clk_data.clks. This cycle can be skipped and the declaration > avoided. > > Signed-off-by: Andi Shyti > --- > drivers/clk/clk-s2mps11.c | 44 +++++++++++++++++++------------------------- > 1 file changed, 19 insertions(+), 25 deletions(-) > > diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c > index cae92fc..09344bb 100644 > --- a/drivers/clk/clk-s2mps11.c > +++ b/drivers/clk/clk-s2mps11.c > @@ -28,9 +28,6 @@ > #include > #include > > -#define s2mps11_name(a) (a->hw.init->name) > - > -static struct clk **clk_table; > static struct clk_onecell_data clk_data; We spoke about this. You don't need both of them. Remove them. Best regards, Krzysztof > > enum { > @@ -139,21 +136,19 @@ static struct device_node *s2mps11_clk_parse_dt(struct platform_device *pdev, > static int s2mps11_clk_probe(struct platform_device *pdev) > { > struct sec_pmic_dev *iodev = dev_get_drvdata(pdev->dev.parent); > - struct s2mps11_clk *s2mps11_clks, *s2mps11_clk; > + struct s2mps11_clk *s2mps11_clks; > unsigned int s2mps11_reg; > int i, ret = 0; > enum sec_device_type hwid = platform_get_device_id(pdev)->driver_data; > > s2mps11_clks = devm_kcalloc(&pdev->dev, S2MPS11_CLKS_NUM, > - sizeof(*s2mps11_clk), GFP_KERNEL); > + sizeof(*s2mps11_clks), GFP_KERNEL); > if (!s2mps11_clks) > return -ENOMEM; > > - s2mps11_clk = s2mps11_clks; > - > - clk_table = devm_kcalloc(&pdev->dev, S2MPS11_CLKS_NUM, > + clk_data.clks = devm_kcalloc(&pdev->dev, S2MPS11_CLKS_NUM, > sizeof(struct clk *), GFP_KERNEL); > - if (!clk_table) > + if (!clk_data.clks) > return -ENOMEM; > > switch (hwid) { > @@ -179,33 +174,32 @@ static int s2mps11_clk_probe(struct platform_device *pdev) > if (IS_ERR(s2mps11_clks->clk_np)) > return PTR_ERR(s2mps11_clks->clk_np); > > - for (i = 0; i < S2MPS11_CLKS_NUM; i++, s2mps11_clk++) { > + for (i = 0; i < S2MPS11_CLKS_NUM; i++) { > if (i == S2MPS11_CLK_CP && hwid == S2MPS14X) > continue; /* Skip clocks not present in some devices */ > - s2mps11_clk->iodev = iodev; > - s2mps11_clk->hw.init = &s2mps11_clks_init[i]; > - s2mps11_clk->mask = 1 << i; > - s2mps11_clk->reg = s2mps11_reg; > - > - s2mps11_clk->clk = devm_clk_register(&pdev->dev, > - &s2mps11_clk->hw); > - if (IS_ERR(s2mps11_clk->clk)) { > + s2mps11_clks[i].iodev = iodev; > + s2mps11_clks[i].hw.init = &s2mps11_clks_init[i]; > + s2mps11_clks[i].mask = 1 << i; > + s2mps11_clks[i].reg = s2mps11_reg; > + > + s2mps11_clks[i].clk = devm_clk_register(&pdev->dev, > + &s2mps11_clks[i].hw); > + if (IS_ERR(s2mps11_clks[i].clk)) { > dev_err(&pdev->dev, "Fail to register : %s\n", > - s2mps11_name(s2mps11_clk)); > - ret = PTR_ERR(s2mps11_clk->clk); > + s2mps11_clks_init[i].name); > + ret = PTR_ERR(s2mps11_clks[i].clk); > goto err_reg; > } > > - s2mps11_clk->lookup = clkdev_create(s2mps11_clk->clk, > - s2mps11_name(s2mps11_clk), NULL); > - if (!s2mps11_clk->lookup) { > + s2mps11_clks[i].lookup = clkdev_create(s2mps11_clks[i].clk, > + s2mps11_clks_init[i].name, NULL); > + if (!s2mps11_clks[i].lookup) { > ret = -ENOMEM; > goto err_reg; > } > - clk_table[i] = s2mps11_clks[i].clk; > + clk_data.clks[i] = s2mps11_clks[i].clk; > } > > - clk_data.clks = clk_table; > clk_data.clk_num = S2MPS11_CLKS_NUM; > of_clk_add_provider(s2mps11_clks->clk_np, of_clk_src_onecell_get, > &clk_data); >