From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933677AbcATBKY (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 Jan 2016 20:10:24 -0500
Received: from sg-smtp01.263.net ([54.255.195.220]:52798 "EHLO
	sg-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S933107AbcATBJV (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 Jan 2016 20:09:21 -0500
X-RL-SENDER: zyw@rock-chips.com
X-FST-TO: linux-arm-kernel@lists.infradead.org
X-SENDER-IP: 103.29.142.67
X-LOGIN-NAME: zyw@rock-chips.com
X-UNIQUE-TAG: <59f760039318f098baaebec6c33e9ee0>
X-ATTACHMENT-NUM: 0
X-DNS-TYPE: 0
Subject: Re: [PATCH v7 5/5] ARM: dts: rockchip: add support mipi panel
 tv080wum-nl0
To: Heiko Stuebner <heiko@sntech.de>
References: <1452053038-32098-1-git-send-email-zyw@rock-chips.com>
 <1452053038-32098-6-git-send-email-zyw@rock-chips.com>
 <1649978.zzK0Pex4sR@phil>
Cc: linux-rockchip@lists.infradead.org, mark.yao@rock-chips.com,
        treding@nvidia.com, Russell King <linux@arm.linux.org.uk>,
        devicetree@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
        linux-kernel@vger.kernel.org,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        linux-arm-kernel@lists.infradead.org
From: Chris Zhong <zyw@rock-chips.com>
Message-ID: <569EDE2F.6060400@rock-chips.com>
Date: Wed, 20 Jan 2016 09:09:03 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <1649978.zzK0Pex4sR@phil>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Heiko

On 01/20/2016 03:26 AM, Heiko Stuebner wrote:
> Hi Chris,
>
> Am Mittwoch, 6. Januar 2016, 12:03:57 schrieb Chris Zhong:
>> This tv080wum-nl0 panel is a mipi panel, it can use in MIPI_TX socket
>> of rk3288 evb board.
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
> [...]
>
>> diff --git a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> b/arch/arm/boot/dts/rk3288-evb-act8846.dts index e662147..7d5475b 100644
>> --- a/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> +++ b/arch/arm/boot/dts/rk3288-evb-act8846.dts
>> @@ -50,6 +50,8 @@
>>   		gpio = <&gpio7 3 GPIO_ACTIVE_HIGH>;
>>   		pinctrl-names = "default";
>>   		pinctrl-0 = <&lcd_en>;
>> +		regulator-always-on;
>> +		regulator-boot-on;
> Is this only needed for the panel itself and can you try to get the panel
> supplies set up correctly instead in that case please?
It is not only for panel, LCDC_VDD need this supply too.
And rk3288-evb-rk808.dts has set this regulator to always on, so I do 
the same thing in here.
>
>
>>   		regulator-name = "vcc_lcd";
>>   		vin-supply = <&vcc_io>;
>>   	};
>> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
>> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4faabdb..0c91858 100644
>> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
>> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
>> @@ -47,7 +47,7 @@
>>   		reg = <0x0 0x80000000>;
>>   	};
>>
>> -	backlight {
>> +	backlight: backlight {
>>   		compatible = "pwm-backlight";
>>   		brightness-levels = <
>>   			  0   1   2   3   4   5   6   7
>> @@ -183,6 +183,16 @@
>>   	status = "okay";
>>   };
>>
>> +&mipi_dsi {
>> +	status = "okay";
>> +	panel {
>> +		compatible ="boe,tv080wum-nl0";
>> +		reg = <0>;
>> +		backlight = <&backlight>;
>> +		status = "okay";
> in the evb-schematics I see, vcc_lcd as supply for the panel.
>
> So I'd think the panel node here should have a
> 	power-supply = <&vcc_lcd>;
> instead of having the always-on above?
>
>
> Thanks
> Heiko
>
>> +	};
>> +};
>> +
>>   &sdmmc {
>>   	bus-width = <4>;
>>   	cap-mmc-highspeed;
>
>
>