From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751380AbcATFWy (ORCPT ); Wed, 20 Jan 2016 00:22:54 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:31592 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750977AbcATFWv (ORCPT ); Wed, 20 Jan 2016 00:22:51 -0500 X-AuditID: cbfec7f4-f79026d00000418a-ba-569f19a7ae7e Subject: Re: [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024 To: Laxman Dewangan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-3-git-send-email-ldewangan@nvidia.com> Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, vreddytalla@nvidia.com, Chaitanya Bandi , Mallikarjun Kasoju From: Krzysztof Kozlowski Message-id: <569F199D.9020207@samsung.com> Date: Wed, 20 Jan 2016 14:22:37 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453198783-28383-3-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t/xK7rLJeeHGcy9Y22x5OJVdouOa4uZ LOae6GCzmPrwCZvF/CPnWC363yxktTj36hELkFjJaPH6haHF0n2rWSzufz3KaPHtSgeTxZQ/ y5ksNs//w2hxedccNoul1y8yWdzbu4LNYsL0tSwWrXuPsFvs7+xgtLgxvYXV4vZvPotVd96z OIh7rJm3htHjcl8vk8eTTRcZPXbOusvusWfiSTaPlcu/sHlsWtXJ5nHn2h42j97md2wefVtW MXpMn/eTyePzJrkAnigum5TUnMyy1CJ9uwSujJ7PzYwFd3kqfm6YxdLAOIuri5GTQ0LAROLn x05GCFtM4sK99WxdjFwcQgJLGSU2zrrIBOE8ZZSY2toLViUsECCxbONSZpCEiMB2JolNN56B JYQE6iV+Nn4Ca2cWmM8k8fX7axaQBJuAscTm5UvYQGxeAS2JyTtawOIsAqoS6/7fA7NFBSIk Dnd2sUPUCEr8mAwR5xRwlZi8Zx5rFyMH0FA9ifsXtUDCzALyEpvXvGWewCgwC0nHLISqWUiq FjAyr2IUTS1NLihOSs811CtOzC0uzUvXS87P3cQIieQvOxgXH7M6xCjAwajEw8vQPC9MiDWx rLgy9xCjBAezkgivPPf8MCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8c3e9DxESSE8sSc1OTS1I LYLJMnFwSjUwpv7K9QjdINSdoq/41lt8+Ta70vlSa8+1z953eUvopznXd66a9cFqr/MZR7c/ nP8YQ7/4H/cuOBr4QUs6kzNdJnDmjwcHRIt165dY3291ft2Y/zD8kK4V5wVWfsmy8j3PkixC z5S/1F+xacWhTRZMLWcsIreaM8znfz7vQ9qxA3sbjX9ePL5unRJLcUaioRZzUXEiAKB2oIng AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.01.2016 19:19, Laxman Dewangan wrote: > MAX77620/MAX20024 are Power Management IC from the MAXIM. > It supports RTC, multiple GPIOs, multiple DCDC and LDOs, > watchdog, clock etc. > > Add MFD drier to provides common support for accessing the > device; additional drivers is developed on respected subsystem > in order to use the functionality of the device. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Chaitanya Bandi > Signed-off-by: Mallikarjun Kasoju > --- > Changes from V1: > - Code cleanups per review from V1. > - Move register acccess APIs from header to c file. > - Remove some of non required variable, remove duplication in error message > and simplify some of function implementation. > - Register RTC driver such that it can get the regmap handle form parent device > > Changes from V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - Drop RTC driver and its i2c client registration. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > drivers/mfd/Kconfig | 15 + > drivers/mfd/Makefile | 1 + > drivers/mfd/max77620.c | 871 +++++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/max77620.h | 404 ++++++++++++++++++++ > 4 files changed, 1291 insertions(+) > create mode 100644 drivers/mfd/max77620.c > create mode 100644 include/linux/mfd/max77620.h > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof