From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751389AbcATF0T (ORCPT ); Wed, 20 Jan 2016 00:26:19 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:51873 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbcATF0G (ORCPT ); Wed, 20 Jan 2016 00:26:06 -0500 X-AuditID: cbfec7f4-f79026d00000418a-38-569f1a6a0531 Subject: Re: [PATCH V4 5/5] regulator: max77620: add regulator driver for max77620/max20024 To: Laxman Dewangan , robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linus.walleij@linaro.org, gnurou@gmail.com, lee.jones@linaro.org, broonie@kernel.org, a.zummo@towertech.it, alexandre.belloni@free-electrons.com References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-6-git-send-email-ldewangan@nvidia.com> Cc: lgirdwood@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, rtc-linux@googlegroups.com, swarren@nvidia.com, treding@nvidia.com, vreddytalla@nvidia.com, Mallikarjun Kasoju From: Krzysztof Kozlowski Message-id: <569F1A67.8080902@samsung.com> Date: Wed, 20 Jan 2016 14:25:59 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453198783-28383-6-git-send-email-ldewangan@nvidia.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t/xK7pZUvPDDLasl7NYcvEqu0XHtcVM FlMfPmGzmH/kHKtF/5uFrBbnXj1iARIrGS1evzC0WLpvNYvF/a9HGS2+XelgspjyZzmTxeb5 fxgtLu+aw2ax9PpFJot7e1ewWUyYvpbFonXvEXaL/Z0djBY3prewWtz+zWex6s57FgcxjzXz 1jB6XO7rZfJ4sukio8fOWXfZPfZMPMnmsXL5FzaPTas62TzuXNvD5tHb/I7No2/LKkaP6fN+ Mnl83iQXwBPFZZOSmpNZllqkb5fAlTFp526mguVcFW8XTWdqYJzF0cXIySEhYCLRPGcqM4Qt JnHh3nq2LkYuDiGBpYwSLRvfQDlPGSUefugGqxIWiJVo3TybGSQhIrCdSWLTjWeMIAkhgXqJ rmdNTCAJZoEfjBI7p69kBUmwCRhLbF6+hA3E5hXQknh7YBlYnEVAVWLr3jdgU0UFIiQOd3ax Q9QISvyYfI8FxOYUcJV48OgWUJwDaKiexP2LWiBhZgF5ic1r3jJPYBSYhaRjFkLVLCRVCxiZ VzGKppYmFxQnpeca6hUn5haX5qXrJefnbmKExO+XHYyLj1kdYhTgYFTi4WVonhcmxJpYVlyZ e4hRgoNZSYRXnnt+mBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHeubvehwgJpCeWpGanphakFsFk mTg4pRoYJ79VaTtg+UXsr+KX1S9CWWI3dWv1712zKXlKqQyrR1XUZRmJzUx30vcZ6r6qlM66 U2nndT3gzN+3IkWSD6ayf32QpF+nU2c7+em3n1Y6eeIdJwS+xDBf1epdMHn+vf+Mm3R2yx6+ IipXPbORrX5D/+xlzT/2mXdOFj63e9OFX6//drx2YZyUqcRSnJFoqMVcVJwIADBAU+/bAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.01.2016 19:19, Laxman Dewangan wrote: > MAXIM Semiconductor's PMIC, MAX77620 and MAX20024 have the > multiple DCDC and LDOs. This supplies the power to different > components of the system. > Also these rails has configuration for ramp time, flexible > power sequence, slew rate etc. > > Add regulator driver to access these rails via regulator APIs. > > Signed-off-by: Laxman Dewangan > Signed-off-by: Mallikarjun Kasoju > --- > Changes from V1: > - Cleanup code based on comment received on mfd/rtc. > - Avoid duplication on error message. > > Changes form V2: > - Run coccicheck and checkpatch in strict mode for the alignment. > - Refactor Regulator driver to use core API for DT parsing. > - Update based on API changes. > > Changes from V3: > - Change all sys initcall to module driver. > - change the max77620_read argument to unisgned int from u8. > > drivers/regulator/Kconfig | 9 + > drivers/regulator/Makefile | 1 + > drivers/regulator/max77620-regulator.c | 883 +++++++++++++++++++++++++++++++++ > 3 files changed, 893 insertions(+) > create mode 100644 drivers/regulator/max77620-regulator.c Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof