From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbcATLoN (ORCPT ); Wed, 20 Jan 2016 06:44:13 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:35496 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751367AbcATLoL (ORCPT ); Wed, 20 Jan 2016 06:44:11 -0500 Subject: Re: [PATCH] sfc: Replace memset with eth_zero_addr To: Lucas Tanure , Shradha Shah References: <1453246074-1054-1-git-send-email-tanure@linux.com> Cc: Solarflare linux maintainers , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <569F7308.9060008@cogentembedded.com> Date: Wed, 20 Jan 2016 14:44:08 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453246074-1054-1-git-send-email-tanure@linux.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 1/20/2016 2:27 AM, Lucas Tanure wrote: > Use eth_zero_addr to assign the zero address to the given address array > instead of memset when second argument is address of zero. What address? memset() takes just 1 address. :-) > Signed-off-by: Lucas Tanure > --- > drivers/net/ethernet/sfc/ef10_sriov.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/sfc/ef10_sriov.c b/drivers/net/ethernet/sfc/ef10_sriov.c > index 3c17f27..10f60db 100644 > --- a/drivers/net/ethernet/sfc/ef10_sriov.c > +++ b/drivers/net/ethernet/sfc/ef10_sriov.c > @@ -527,7 +527,7 @@ int efx_ef10_sriov_set_vf_mac(struct efx_nic *efx, int vf_i, u8 *mac) > return 0; > > fail: > - memset(vf->mac, 0, ETH_ALEN); > + eth_zero_addr(vf->mac); > return rc; > } > MBR, Sergei