From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934593AbcATQKr (ORCPT ); Wed, 20 Jan 2016 11:10:47 -0500 Received: from mail-by2on0085.outbound.protection.outlook.com ([207.46.100.85]:28592 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933838AbcATQKn (ORCPT ); Wed, 20 Jan 2016 11:10:43 -0500 Authentication-Results: spf=pass (sender IP is 63.163.107.172) smtp.mailfrom=sandisk.com; lists.infradead.org; dkim=none (message not signed) header.d=none;lists.infradead.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160a68-2a63198000007278-c3-569fb17e004e Subject: Re: [PATCH] scsi: qla2xxxx: avoid type mismatch in comparison To: Arnd Bergmann , Nicholas Bellinger References: <1603472.f34vvTrhuN@wuerfel> CC: , "James E.J. Bottomley" , "Martin K. Petersen" , , , , Alexei Potashnik , Quinn Tran , "Himanshu Madhani" , Hannes Reinecke From: Bart Van Assche Message-ID: <569FB178.9050101@sandisk.com> Date: Wed, 20 Jan 2016 08:10:32 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1603472.f34vvTrhuN@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRmVeSWpSXmKPExsWyRoxnkW7dxvlhBo9O8lvcbVrCaPF30jF2 iwVv9rJZvPjxhNXi//rbLBabHl9jtbi8aw6bRff1HWwWy4//Y7JoW32G0eJgz0Nmi2s33jI7 8Hj8/jWJ0eP+9iNMHpuX1Hsc/vGD2ePj01ssHtse9rJ7rPtygt1j/ZarLB6fN8kFcEZx2aSk 5mSWpRbp2yVwZXQ//cFW0M1X0X72DksD42ruLkZODgkBE4mOBV+Yuxi5OIQENjFKfN7VzQbh 7GCUOH30MCNM1ZS+P2wgtpDAHEaJbZuMQWxhATeJB8sb2LsYOThEBLwlrmyuADGFBDQkOk8F gIxhFpjELPF4WzsrSDmbgJHEt/czWUBsXgEtiR19p9lBbBYBVYkHr7cxgdiiAhESPzYsYYSo EZQ4OfMJWD2ngKbEkjdNbCDzmQXsJR5sLQMJMwvIS2x/OwfsfgmBHjaJDzuXMEOcqS5xcsl8 pgmMwrOQjJqF0D4LSfsCRuZVjGK5mTnFuempBYaGesWJeSmZxdl6yfm5mxjBUciVsYNx6yTz Q4wCHIxKPLwMzfPChFgTy4orcw8xSnAwK4nwii+dHybEm5JYWZValB9fVJqTWnyIUZqDRUmc 17pFLUxIID2xJDU7NbUgtQgmy8TBKdXAOO2P+ctXeh35rs8fnPlZ6p96xXyXWf+D7mcCnO7a n/OSWxR/Hzm8J59NKPb6w186jDyfX++8UH/97eUoR/E24WrTbwZzNgVzOESHleyYo3PceNrr cLnOgjYLmc8fm2Qn3LLLt9y4eeb6hO7tJovLubg+BWu5PI/VENXpeqrrKnDIdX9KvD2zEktx RqKhFnNRcSIAF7HmW74CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsXCtZEjRbdi4/wwg5fTxC3uNi1htPg76Ri7 xYI3e9ksXvx4wmrxf/1tFotNj6+xWlzeNYfNovv6DjaL5cf/MVm0rT7DaHGw5yGzxbUbb5kd eDx+/5rE6HF/+xEmj81L6j0O//jB7PHx6S0Wj20Pe9k91n05we6xfstVFo/Pm+QCOKO4bFJS czLLUov07RK4Mrqf/mAr6OaraD97h6WBcTV3FyMnh4SAicSUvj9sXYxcHEICsxglTu+9xQKS EBZwk3iwvIG9i5GDQ0TAW+LK5goQU0hAQ6LzVABIObNAD7PE9lMTwMrZBIwkvr2fCWbzCmhJ 7Og7zQ5iswioSjx4vY0JxBYViJD4sWEJI0SNoMTJmU/A6jkFNCWWvGliA7GZBWwl7szdzQxh y0tsfzuHeQIj3ywkLbOQlM1CUraAkXkVo1huZk5xbnpmgaGhXnFiXkpmcbZecn7uJkZwNHBG 7mB8OtH8ECMTB6dUA2N08voqVbHQ1z8FeDXPWd99WHfL+bmu1DaNzxNZtFdLxQbcX9rXInRL 5UHzAjNNx4AzkhEr/acJXDWXl2O0Cwvz3XWnfvHcWU+uSE/q0tdvzJglydLK4ro45YC92cLe K3FFRjrfV07PCLiR3sF5feLKZYY9uufzGM58NZbKbT/6kHnmtWg+RiWW4oxEQy3mouJEACge agk2AgAA X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD015;1:ymb/j499dYuDaOqFtb0eOnFFGFRYexPNwwwgnqzbqB60vEIo6oHcU9iGk/wpItQrIq+QV/rJ2kC9o9HRKomj2+x5Wt45qoWN7JkGavXoaVOSmBfU0Xl9tn9IdJh41ND9z3P4lLwK842XyyWrVOgbzuZ8p4Fcf9tQVeDEDUjsX4EcSD5fc1MVTp9QYzgZ4LVgZg3M9ZsPG5dXuj4ROhJQiAd3JdT85hbDiQbOVht04yyOYN10+4ycUxb6HOsFi1QMZPwKCY17v0/yvozMmt4rO9PI5IpXKhNY/4BcFV7N6SWeOIpIUZIKWBeAFoAhvZPj4c//tpXVHfeaFrtNqZ0XAzFdL1UUYljDTzEB8KrAoC8B0LiRUXpxibde8fxl7WXji1mRJkOnGzj4huwABAda4mRFo4Qeg9JeOdf6DPbFJN6sRsCmZNT8eqKwTNzOqcIPKPBSmBXqHCmEYR40o27Nug== X-Forefront-Antispam-Report: CIP:63.163.107.172;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(438002)(164054003)(479174004)(377454003)(199003)(189002)(24454002)(69596002)(50466002)(59896002)(33656002)(65806001)(11100500001)(19580405001)(19580395003)(15975445007)(189998001)(65956001)(80316001)(47776003)(54356999)(106466001)(87936001)(65816999)(83506001)(81156007)(64126003)(97736004)(23746002)(5001770100001)(50986999)(76176999)(87266999)(4001350100001)(77096005)(586003)(2950100001)(1096002)(2906002)(4326007)(5008740100001)(86362001)(230700001)(5001960100002)(1220700001)(92566002)(36756003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR0201MB0826;H:milsmgep11.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0826;2:AFzO1JqnCJ+VdSbs7wziI+hTXgbODz/ZOAJgvAR+soCRu3b9c/e6t8YzpaHvcMvpVC881a3KpO0FH78i5ZZvhaNRsvP4unXLKqgT/yakFOD72iPI/haxxIihY21HFxvltD4vldOVFtGmUQq+mjCssg==;3:AAwZz+DiySLBLF47TVD2xp/fTXHrDtTnaJesvCvwGLFJzHtFiyiLPF2ErT9fbENgSiYtXJfEDy4t9a7gYymWJA1b/zwzd3lIGowXjRrBHdU/YnTVxLpa9Z6cKHXVkXjDyovpFrTLVcY4SygsxBRDgfg7JTlu7arGGYByqtGQScOTlCnReEttKfsmiCVYlrAcbKRZ5fmnktnyYWrhvVmVMAXP/gSnh1gEzxyfEA05ApWZYNcMu6HhhAfnn2TlSglP2oDQvpzA5blX0KQAGvKqAA==;25:neVdq7HhusOKMv247HT7uxXFhrRoyNX5I3hCK9koiqj7UY5I+N7Z9qcCzx4Y5c/32DUduWhD7RgAxwari5Tu488lzFEDc+1PI5oHrXoKFdHmMJX67BogUxSUdOr+3+6aHVErs/RxwCOj7uZsyNwXA5tDGvinenYnX+J2bYejxruHhzAHOw7rhjljAEQkPr2wqhxZB6itgT89aZNnHLt4EwKmD1CVAafmUdjFEzZ0UzrabU0RbcIaaVKU/XRmYJji X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:CY1PR0201MB0826; X-MS-Office365-Filtering-Correlation-Id: e6a77161-1cf4-458f-7ded-08d321b43db0 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0826;20:Ju9jMxglO1ab3AyBqGDagd4o2972zwtglip5kruDoXS3pEK+eumHKnZqUEnpJzVvynCXWPdeYzE87LyFWCAEp8KZRwim1HyiTDsRKCNTtx+n3foe3eUZBWWSEhWWxO+PnMDnEW4vZBgCV6ut6gxD4T058RlLax314mtvzIM0G4bc5+CgdROou3A5vS2jijKG8Vdtc307yeePKXx8JKS7e1dJ11+f9ENaLb27K5UdzhHgI93UDVeikIelr0sdidvAGv2pkl6KiwirquKJ0yVng/RX/DffoPT5SS5hpRr7DSLd+L8VXF806T+fLalkVoz8rrLd0Q8fB/FHckKNvnNwYf1yvIriMzkIuj5xZ0arN5ytqmxMO3WSa0XGlv5lx0v3zTZzGYv+yULnBY0/RAPeMhNvCr75ot++s91BLpEVQsdOWzcszW0K27vY8gyRfFIcXA5nhEkovq8/+ahHGnadVC0je7pW0C+1dq5AuDq9x3vBxE4k8HJQ3WLxF6CMEI1P X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13017025)(13023025)(13018025)(13015025)(520078)(13024025)(8121501046)(5005006)(3002001)(10201501046);SRVR:CY1PR0201MB0826;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0201MB0826; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0826;4:a67S3G1uSRNw0dKbhTOhfGJT38/hqZNfEtLXcjkaOAlQBqVtfkCNfnkvQ2GzKnE6H8ztOTEeYNWlzJC1XNixYLk6us6qHiypIOYMaBbIqHzK1cbBoDaU2bKmSPzYY9+6b/tCeFYZAUYDXMJle4K7Ltrtf3Ds58BQTtPwxjMwLaph9Yl4Cj6sx9ERZp0Kcu43siU/z3a6tSVfft36JbrCsxkSl5eJbTU2rtnaoGpgEMYGcxjfYMigvfWQESo/EHHSalKLjzuHw6NfHe4gjP60Pv+FhlYuMJm3WlqVtkqqfwkCfuhgoNTUQPdr/tyi2KdW5mo/ftc6HlLGGQamb7JjTMvjtwhpL8HRcLbDiTCn+P8ft8A9ixUlwLC/Ib6iE6We9w3oYAPN9UJQeS7KLLucibGo1WCBbNyhXXahDL4EKz/PzH7fHARp1nIG2cEpzzkfOMs/TmUKVeTwQJw2iN4eJWvQkGn3vtHIy2mAI+iA5eQ= X-Forefront-PRVS: 0827D7ACB9 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR0201MB0826;23:lOIm0Dasz5pCG85BwWzkFBUw+WLkVLKeJTG?= =?Windows-1252?Q?MARx3l5X/rFy+chDEBjTc4P7OunJT7VgE7iGKwszas7LA6ueGTxSESLi?= =?Windows-1252?Q?SGVQie6VZyx9KfXx6kZJm+rCqGNaHm8PQYiJ4eMzXjfOSJYQLGfwp2bG?= =?Windows-1252?Q?1ZCao8b0j1ATld0x/KPq+qOhtR3RlAhh45zagIWChbxhQgzTuPnymsrZ?= =?Windows-1252?Q?jbKPiV9ET/9yhGzuMt8qai1mYuSDZAK/6KTnj6ghg1B5yfN/0JT65Ztz?= =?Windows-1252?Q?RtTNrnuEGNRCYZ/GKv8ICpr1ou1jFdvhkKngSf9gHJ01/peW8k7oHSYw?= =?Windows-1252?Q?cIruWC2WemY5KAA4M0HxTWCHaySeDxOrNX+pCC1MlNEVfLaKJhE6KJd4?= =?Windows-1252?Q?5sR5fWPmuZbaMQyTomKa7uJA4tZ+9MPEaxrinsIhQMQQyVUCn4s9pY3G?= =?Windows-1252?Q?VHPCu030xwPHocNebrJAJyoc5QLDqZ49WW9acir3bCnvRjhZk+g/zSMR?= =?Windows-1252?Q?KBEMve3YXtr38aaW6z4/EkYB8ymHE1vNR2XapMzYfd3eixqEzPdG9Ojb?= =?Windows-1252?Q?fOE6qRx3vXFaRLyXuaVAbXbceQz+QgigFrZofdYOeVAjaSuJvjknfrlO?= =?Windows-1252?Q?QxLiSYSXSPiUl0izpYyQvw8S1tv8Br35UuJ+nL+GQwGld9FcRfoXbwP2?= =?Windows-1252?Q?VYIJe0DxzSWRyrWgNzDNBTiAQ0l1zdWVdSaxif58R5t0Qb+SPAtHdFXY?= =?Windows-1252?Q?yNDyKm0woBTfjhUHCu6CGDVT6fNfHk9Ssja8dfygaM9xB0KgPENk1nQE?= =?Windows-1252?Q?l/11260j6lIzvQ50h4spAGClvfeAvEH63rN9O3wN0365HWFYmt1i/nxZ?= =?Windows-1252?Q?LxKTq2nW5nzIkkXdofAUWF5Fm8YRPyWyorWE86LDcefaU+UYtygD8l6T?= =?Windows-1252?Q?osA5fXuDTjfY7mEdhx0MPbeZdXhj/AkTSzWWiBVJp63ulvJVRu+4DbIp?= =?Windows-1252?Q?ouXQ3kaMlqI/GJFGjWdJvjmrUjrLreYqHH4mWfnHbpGgj/9Gxc+BhBv4?= =?Windows-1252?Q?hOn67IOIoiEx3dlrAqkkvNySNZnWKKPUy0gDie5XfxyY/pIgZkGZdlzn?= =?Windows-1252?Q?8iHaTieETJOuiiVYJpF/6lr2DU86jHwyZr72sGTLCFeDs+yTArYjaqSF?= =?Windows-1252?Q?Iw6Ut7ie8nxX9rlCwxUJGze37rTeDwuRAHQog3YPe2lt39TF2vaHndcI?= =?Windows-1252?Q?Oki+hP5JL+bpgeVQqX9A0JA31GlHX5N6zdM0qxx9K+3lihcVAOFY+rtN?= =?Windows-1252?Q?r7DLXEBPlxtZc7lAvJ5T3Yu7HX+RfkXfDawoM7CT6E6swbpo3vxgf1NM?= =?Windows-1252?Q?2hIYS/uNOPOnM?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0826;5:PBPYcTInz07pBbGIpKnij60LqqS7W3WKdvx/DFpkKD8Parrj5a30RbtKBy0drOuPezqqdBa9vW3o+RPMWIXCWBNsnMAb7RbYMQEF5DLdyTU/bG7X269TRbvzVoUz0HCQ+uJEUQGIkzWr6SstJ+BDrw==;24:vWxbkk466WuyewtGSScwDax9t4Aac7JIafyk283I0NT4P6RgYty5D9DMRikUBwjFZmDkBMR3iO/Dg+a5Z2vWc6vf4aGGHjTrkeD86GQbma8=;20:J+lu6OVEdX9opz823gWdZWNKyIwTlLygppkIOBvxuIvFgTbXzdL5iWGRgsfhcKtBW408TRsTWVq6L8iu27M6oQfaN/lYLssySMf8x2ovE+HcYD0ZEIPjCdh7BEU7GY7Oyi9QTtX7qP3CDHaFZott5mhd1TS1UzFmzdwk9VOFbzRntRW7Y7rYYhOQYFvdiRawo+NYA/xDJ0FD9maDEae61tdKP2kkYjrdZGEeIk8LnrfMAVVkVozoAXkSQHI7Ouuv SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jan 2016 16:10:38.3458 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.172];Helo=[milsmgep11.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0201MB0826 X-Microsoft-Exchange-Diagnostics: 1;CY1PR0201MB0985;2:BItGymjHtxXNROxy74BBdCaD1Aca0yAzu4DoEjSdazBQEyi/uAXpUHH/wP+FFDPoR5iQMbfDggDAIyEKR8ToPZ8auRcfK1xD9CaXxANSyUvF4sOcb/Uz5ukPnNXb//JoVK4Burh3H79Xq+HQ9rrLgQ==;23:6kzE8Mfgm6PFLBSjJxLsW+Jt7rnpPe4efmBaiZxBNMKDSUbASPRDpMN7zngeMkcU6WZ3mi29efm6hHDZMC2SMkTBepb3u73NA8AYyHBnICeN5Nf0siIxKOWG3Mw2YK8IFNX0i33c36L0WJou0LAgVSIjgKiwfWTL4zR8w7wVcNfbVxSDHQfDYXA14fTKD5kK X-OriginatorOrg: sandisk.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2016 02:47 AM, Arnd Bergmann wrote: > A recent bug fix added code that does > > bool logged_out = (status & 0xFFFF); > if (logged_out == CTIO_PORT_LOGGED_OUT) > ... > > This looks wrong because we are comparing a boolean with an > integer constant, ang gcc warns about it accordingly: > > drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion': > drivers/scsi/qla2xxx/qla_target.c:3587:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare] > (logged_out == CTIO_PORT_LOGGED_OUT) ? > > The correct fix is presumably to make that variable an 'int'. > > Signed-off-by: Arnd Bergmann > Fixes: 71cdc0796465 ("qla2xxx: Delete session if initiator is gone from FW") > --- > The patch introducing this is currenly in linux-next through the target-updates/for-next > branch. > > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index c7ab9e69c881..8075a4cdb45c 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -3580,7 +3580,7 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle, > case CTIO_PORT_LOGGED_OUT: > case CTIO_PORT_UNAVAILABLE: > { > - bool logged_out = (status & 0xFFFF); > + int logged_out = (status & 0xFFFF); > ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059, > "qla_target(%d): CTIO with %s status %x " > "received (state %x, se_cmd %p)\n", vha->vp_idx, > Hello Arnd, Please read the e-mail thread that is available at http://thread.gmane.org/gmane.linux.scsi/108899/focus=108943. That thread namely makes it clear that the above patch is not the proper way to fix that code. Thanks, Bart.