From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934999AbcATRTZ (ORCPT ); Wed, 20 Jan 2016 12:19:25 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:11179 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934015AbcATRTX (ORCPT ); Wed, 20 Jan 2016 12:19:23 -0500 Subject: Re: [PATH v2] NVMe: init nvme queue before enabling irq To: Greg KH , Wenbo Wang References: <1453286915-18814-1-git-send-email-mail_weber_wang@163.com> <20160120171223.GA28243@kroah.com> CC: , , , , , Wenbo Wang From: Jens Axboe Message-ID: <569FC116.5060109@fb.com> Date: Wed, 20 Jan 2016 10:17:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160120171223.GA28243@kroah.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-01-20_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2016 10:12 AM, Greg KH wrote: > On Wed, Jan 20, 2016 at 05:48:35AM -0500, Wenbo Wang wrote: >> From: Wenbo Wang >> >> During reset process, the nvme_dev->bar (ioremapped) may change, >> so nvmeq->q_db shall be also updated by nvme_init_queue(). >> >> Currently nvmeq irq is enabled before queue init, so a spurious >> interrupt triggered nvme_process_cq may access nvmeq->q_db just >> before it is updated, this could cause kernel panic. >> >> Signed-off-by: Wenbo Wang >> Reviewed-by: Wenwei Tao >> --- >> drivers/nvme/host/pci.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) > > > > This is not the correct way to submit patches for inclusion in the > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. I'll mark it stable when adding, just ignore it for now. -- Jens Axboe