From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757430AbcATSzT (ORCPT ); Wed, 20 Jan 2016 13:55:19 -0500 Received: from mail-oi0-f66.google.com ([209.85.218.66]:35169 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbcATSzP (ORCPT ); Wed, 20 Jan 2016 13:55:15 -0500 Subject: Re: [PATCH v2 2/2] kbuild: Remove stale asm-generic wrappers To: James Hogan , Michal Marek References: <1453210670-12596-1-git-send-email-james.hogan@imgtec.com> <1453210670-12596-3-git-send-email-james.hogan@imgtec.com> Cc: linux-kernel@vger.kernel.org, Heinrich Schuchardt , Arnd Bergmann , Ralf Baechle , Paul Burton , linux-kbuild@vger.kernel.org, linux-arch@vger.kernel.org, linux-mips@linux-mips.org From: Florian Fainelli Message-ID: <569FD80F.2000109@gmail.com> Date: Wed, 20 Jan 2016 10:55:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453210670-12596-3-git-send-email-james.hogan@imgtec.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 19/01/2016 05:37, James Hogan a écrit : > When a header file is removed from generic-y (often accompanied by the > addition of an arch specific header), the generated wrapper file will > persist, and in some cases may still take precedence over the new arch > header. > > For example commit f1fe2d21f4e1 ("MIPS: Add definitions for extended > context") removed ucontext.h from generic-y in arch/mips/include/asm/, > and added an arch/mips/include/uapi/asm/ucontext.h. The continued use of > the wrapper when reusing a dirty build tree resulted in build failures > in arch/mips/kernel/signal.c: > > arch/mips/kernel/signal.c: In function ‘sc_to_extcontext’: > arch/mips/kernel/signal.c:142:12: error: ‘struct ucontext’ has no member named ‘uc_extcontext’ > return &uc->uc_extcontext; > ^ > > Fix by detecting and removing wrapper headers in generated header > directories that do not correspond to a filename in generic-y, genhdr-y, > or the newly introduced generated-y. > > Reported-by: Jacek Anaszewski > Reported-by: Hauke Mehrtens > Reported-by: Heinrich Schuchardt > Signed-off-by: James Hogan Acked-by: Florian Fainelli Thanks for looking into this James. > Cc: Michal Marek > Cc: Arnd Bergmann > Cc: Ralf Baechle > Cc: Paul Burton > Cc: Florian Fainelli > Cc: linux-kbuild@vger.kernel.org > Cc: linux-arch@vger.kernel.org > Cc: linux-mips@linux-mips.org > --- > Changes in v2: > - Rewrite a bit, drawing inspiration from Makefile.headersinst. > - Exclude genhdr-y and generated-y (thanks to kbuild test robot). > --- > scripts/Makefile.asm-generic | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/scripts/Makefile.asm-generic b/scripts/Makefile.asm-generic > index 045e0098e962..24c29f16f029 100644 > --- a/scripts/Makefile.asm-generic > +++ b/scripts/Makefile.asm-generic > @@ -13,11 +13,26 @@ include scripts/Kbuild.include > # Create output directory if not already present > _dummy := $(shell [ -d $(obj) ] || mkdir -p $(obj)) > > +# Stale wrappers when the corresponding files are removed from generic-y > +# need removing. > +generated-y := $(generic-y) $(genhdr-y) $(generated-y) > +all-files := $(patsubst %, $(obj)/%, $(generated-y)) > +old-headers := $(wildcard $(obj)/*.h) > +unwanted := $(filter-out $(all-files),$(old-headers)) > + > quiet_cmd_wrap = WRAP $@ > cmd_wrap = echo "\#include " >$@ > > -all: $(patsubst %, $(obj)/%, $(generic-y)) > +quiet_cmd_remove = REMOVE $(unwanted) > +cmd_remove = rm -f $(unwanted) > + > +all: $(patsubst %, $(obj)/%, $(generic-y)) FORCE > + $(if $(unwanted),$(call cmd,remove),) > @: > > $(obj)/%.h: > $(call cmd,wrap) > + > +.PHONY: $(PHONY) > +PHONY += FORCE > +FORCE: ; > -- Florian