From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752437AbcAUAYB (ORCPT ); Wed, 20 Jan 2016 19:24:01 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:17584 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcAUAX4 (ORCPT ); Wed, 20 Jan 2016 19:23:56 -0500 X-AuditID: cbfec7f5-f79b16d000005389-74-56a025192fad Subject: Re: [PATCH v3 2/4] clk: s2mps11: allocate only one structure for clock init To: Andi Shyti , linux-samsung-soc@vger.kernel.org References: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> <1453284864-8082-3-git-send-email-andi.shyti@samsung.com> Cc: Sangbeom Kim , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar , Jaehoon Chung From: Krzysztof Kozlowski Message-id: <56A02519.4050207@samsung.com> Date: Thu, 21 Jan 2016 09:23:53 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453284864-8082-3-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t/xy7qSqgvCDM49FbHYfuQZq8XiH8+Z LG78amO1eP3C0OJjzz1Wi8u75rBZzDi/j8ni4ilXi4srvjBZ/DjTzWIx93cjqwO3x/sbrewe l/t6mTyuL/nE7LFz1l12j74tqxg9Pm+SC2CL4rJJSc3JLEst0rdL4MpYeug7e8FhjooFF7ey NDD+Yeti5OSQEDCRuPH3OpQtJnHh3nogm4tDSGApo8T9500sEM5TRonD31+BVQkLhEmcX9bH DGKLCHhJTH14ghGiqJFR4taut8wgDrPABiaJ1Tdvs4NUsQkYS2xevgSsm1dAS2Lx2eNMIDaL gKrEyjW/GUFsUYEIicOdXewQNYISPybfYwGxOQXcJPb0NAD1cgAN1ZO4f1ELJMwsIC+xec1b 5gmMArOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJCo+LqDcekxq0OM AhyMSjy8N67NDxNiTSwrrsw9xCjBwawkwvtVdEGYEG9KYmVValF+fFFpTmrxIUZpDhYlcd6Z u96HCAmkJ5akZqemFqQWwWSZODilGhi7c/Zt9r93o8t0b2HtDjHXHXM4JzTKV5il+bnGyp7o uGgmahdtFrR/1dFs89lrnf4x3QzaVF1/RPbDFSaW6wyH383lM9z4Z6rc3ZzjF24dkgl6O1VJ Wb9xrUBL//ey6XsqPLZyhUp0C+xVvrbQfZ6F70Ij5zjtgCVrptYaXuRqzL+j2re+ol6JpTgj 0VCLuag4EQBaeSYYhgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.01.2016 19:14, Andi Shyti wrote: > The driver allocates three structures, s2mpsxx_clk_init, for > three different clock types (s2mps11, s2mps13 and s2mps14). They > are quite similar but they differ only by the name. Only one of > these structures is used, while the others lie unused in the > memory. > > The clock's name, though, is not such a meaningful information > and by assigning the same name to the initial data we can avoid > over allocation. The common name chosen will be s2mps11, > coherently with the device driver name, instead of the clock > device. > > Therefore, remove the structures associated to s2mps13 and > s2mps14 and use only the one referred to s2mps11 for all kind of > clocks. > > Signed-off-by: Andi Shyti > Suggested-by: Krzysztof Kozlowski > --- > drivers/clk/clk-s2mps11.c | 51 +++++++---------------------------------------- > 1 file changed, 7 insertions(+), 44 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof