From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751847AbcAUA3T (ORCPT ); Wed, 20 Jan 2016 19:29:19 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:17643 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbcAUA3Q (ORCPT ); Wed, 20 Jan 2016 19:29:16 -0500 X-AuditID: cbfec7f5-f79b16d000005389-cb-56a02659efe0 Subject: Re: [PATCH v3 4/4] clk: s2mps11: remove redundant code To: Andi Shyti , linux-samsung-soc@vger.kernel.org References: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> <1453284864-8082-5-git-send-email-andi.shyti@samsung.com> Cc: Sangbeom Kim , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar , Jaehoon Chung From: Krzysztof Kozlowski Message-id: <56A0265A.2000307@samsung.com> Date: Thu, 21 Jan 2016 09:29:14 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453284864-8082-5-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrELMWRmVeSWpSXmKPExsVy+t/xK7qRagvCDM5NMbLYfuQZq8XiH8+Z LG78amO1eP3C0OJjzz1Wi8u75rBZzDi/j8ni4ilXi4srvjBZ/DjTzWIx93cjqwO3x/sbrewe l/t6mTyuL/nE7LFz1l12j74tqxg9Pm+SC2CL4rJJSc3JLEst0rdL4Mp4dfUnW8Fx1oqm25PZ GhiPsHQxcnBICJhITP0d08XICWSKSVy4t56ti5GLQ0hgKaPE/Q/7oZynjBKvT+1nB6kSFrCX WPP1MyOILSLgJTH14QlGiKJGRom3P6eBOcwCG5gkVt+8DdbBJmAssXn5EjYQm1dAS6Lp2wlm EJtFQFVi6vRvrCC2qECExOHOLnaIGkGJH5PvsYDYnAJuEncf3mUFOZVZQE/i/kUtkDCzgLzE 5jVvmScwCsxC0jELoWoWkqoFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MUJi4usOxqXH rA4xCnAwKvHw3rg2P0yINbGsuDL3EKMEB7OSCK+cyoIwId6UxMqq1KL8+KLSnNTiQ4zSHCxK 4rwzd70PERJITyxJzU5NLUgtgskycXBKNTAunHHuJd/pVTFbepiiFu7WnzzpRJ3o0/hMQzXe ST/fTTASsFc/JDPtTe/shgdfdu851pWRKWDafS5/HpP69RUZbLOU/PZe2TBX9bviyi8X2HV/ dW650FQ3+2hnR+Bby4Vhj39487xf9GJlUYtH17KirVu6PjG+qo3U/dN7QX7ChoVfwrhZS6s5 lFiKMxINtZiLihMBUOdF3oUCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.01.2016 19:14, Andi Shyti wrote: > The definition of s2mps11_name is meant to resolve the name of a > given clock. Remove it because the clocks have the same name we > can get it directly from the s2mps11_clks_init structure. > > While in the probe function the s2mps11_clks is used only to > iterate through the s2mps11_clks. The naming itself brings > confusion and the readability does not improve much. > > Signed-off-by: Andi Shyti > --- > drivers/clk/clk-s2mps11.c | 36 ++++++++++++++++-------------------- > 1 file changed, 16 insertions(+), 20 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof