From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: Kukjin Kim <kgene@kernel.org>,
rtc-linux@googlegroups.com, Chanwoo Choi <cw00.choi@samsung.com>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
linux-samsung-soc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/8] rtc: max77686: Extend driver and add max77802 support
Date: Thu, 21 Jan 2016 09:48:20 +0900 [thread overview]
Message-ID: <56A02AD4.40107@samsung.com> (raw)
In-Reply-To: <1453310088-29985-1-git-send-email-javier@osg.samsung.com>
On 21.01.2016 02:14, Javier Martinez Canillas wrote:
> Hello,
>
> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan,
> we came to the conclusion that the max77686 and max77802 RTC are almost
> the same with only a few differences so there shouldn't be two separate
> drivers and is better to extend max77686 driver and delete rtc-max77802.
>
> By making the driver more generic, other RTC IP blocks from Maxim PMICs
> could be supported as well like the max77620.
>
> Patches #1 is just a trivial cleanup.
>
> Patch #2 allows to support RTCs that need a shorter delay when updating
> the RTC.
>
> Patch #3 adds a driver data structure to avoid hard-coding parameters
> specific to a certain RTC such as the needed delay and RTC register mask.
>
> Patch #4 changes the driver to use a mapping table instead of using the
> max77686 registers offsets directly to allow supporting RTC with other
> registers addresses and layout.
>
> Patch #5 Adds support for max77802 to max77686 RTC driver and patch #6
> removes the old driver since is not needed anymore.
>
> Finally patch #7 and patch #8 removes the Kconfig symbol from defconfigs.
>
> I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has
> a max77802 PMIC and the RTC was working correctly but I don't have a
> machine with max77686 so I will really appreaciate if someone can test
> that no regressions were introduced.
>
Thanks for the submission. I like the approach. I'll start reviewing the
code and testing it... or maybe I'll wait with testing for v2 because I
already sent some comments. :)
Anyway I will provide later tested-by on max77686.
Best regards,
Krzysztof
next prev parent reply other threads:[~2016-01-21 0:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 17:14 [PATCH 0/8] rtc: max77686: Extend driver and add max77802 support Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 1/8] rtc: max77686: Use ARRAY_SIZE() instead of current array length Javier Martinez Canillas
2016-01-21 0:35 ` Krzysztof Kozlowski
2016-01-20 17:14 ` [PATCH 2/8] rtc: max77686: Use usleep_range() instead of msleep() Javier Martinez Canillas
2016-01-21 0:37 ` Krzysztof Kozlowski
2016-01-21 14:52 ` Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 3/8] rtc: max77686: Use a driver data struct instead hard-coded values Javier Martinez Canillas
2016-01-21 0:45 ` Krzysztof Kozlowski
2016-01-21 14:55 ` Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 4/8] rtc: max77686: Add an indirection level to access RTC registers Javier Martinez Canillas
2016-01-21 1:05 ` Krzysztof Kozlowski
2016-01-21 14:57 ` Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 5/8] rtc: max77686: Add max77802 support Javier Martinez Canillas
2016-01-21 1:56 ` Krzysztof Kozlowski
2016-01-21 15:12 ` Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 6/8] rtc: Remove Maxim 77802 driver Javier Martinez Canillas
2016-01-21 1:57 ` Krzysztof Kozlowski
2016-01-21 15:12 ` Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 7/8] ARM: exynos_defconfig: Remove MAX77802 RTC Kconfig symbol Javier Martinez Canillas
2016-01-21 1:58 ` Krzysztof Kozlowski
2016-01-21 15:14 ` Javier Martinez Canillas
2016-01-20 17:14 ` [PATCH 8/8] ARM: multi_v7_defconfig: " Javier Martinez Canillas
2016-01-21 1:58 ` Krzysztof Kozlowski
2016-01-21 0:30 ` [PATCH 0/8] rtc: max77686: Extend driver and add max77802 support Alexandre Belloni
2016-01-21 0:34 ` Krzysztof Kozlowski
2016-01-21 14:50 ` Javier Martinez Canillas
2016-01-21 0:48 ` Krzysztof Kozlowski [this message]
2016-01-21 15:15 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A02AD4.40107@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).