From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758943AbcAUAs5 (ORCPT ); Wed, 20 Jan 2016 19:48:57 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:38437 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758911AbcAUAsW (ORCPT ); Wed, 20 Jan 2016 19:48:22 -0500 X-AuditID: cbfec7f4-f79026d00000418a-cc-56a02ad4d6b7 Subject: Re: [PATCH 0/8] rtc: max77686: Extend driver and add max77802 support To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453310088-29985-1-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org, Arnd Bergmann , Olof Johansson , linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski Message-id: <56A02AD4.40107@samsung.com> Date: Thu, 21 Jan 2016 09:48:20 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453310088-29985-1-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupikeLIzCtJLcpLzFFi42I5/e/4Fd0rWgvCDL6s5bDouLaYyeLvpGPs Fte/PGe1ePN2DZPF6xeGFv2PXzNbLN23msVi0+NrrBaXd81hs5hxfh+Txanrn9ks9nd2MDrw ePz+NYnR48mmi4weeyaeZPPYtKqTzWPzknqPKyeaWD16m9+xeWzpv8vu0bdlFaPH501yAVxR XDYpqTmZZalF+nYJXBlPz+xjL9jDWzFrwg3GBsYrXF2MnBwSAiYS7U9nsEHYYhIX7q0Hsrk4 hASWMkrs6H7DCuE8ZZRYPeEMK0iVsICfRH/bD7AOEYFQiX8XbzN2MXIAFblJXJ1mAVLPLHCD SeLX6qXsIDVsAsYSm5cvAavnFdCQ+HZwPpjNIqAqceDGHGYQW1QgQuJwZxc7RI2gxI/J91hA bE4Bd4neC8uYQOYzC+hJ3L+oBRJmFpCX2LzmLfMERoFZSDpmIVTNQlK1gJF5FaNoamlyQXFS eq6hXnFibnFpXrpecn7uJkZIDH3Zwbj4mNUhRgEORiUe3hvX5ocJsSaWFVfmHmKU4GBWEuGV U1kQJsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6YklqdmpqQWpRTBZJg5OqQZGFwPl Q7fuM0xd47bJ/uV9mesPp+fG1SXG7zc4tU3s0sxdtSlLdhu3BofPNrcuk3KYGvlzu5tp8ssH uhwTPm3ljWZVKJQ9tuWBsUKE2Tn9nCd5/6bPU35WO6ns+qQlfF9dV1tY8DyzujBjxpTSw613 ptWt3zfVcuLEdY1/P5dNmBvVPuNx/Z+e2UosxRmJhlrMRcWJAGaYiimdAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.01.2016 02:14, Javier Martinez Canillas wrote: > Hello, > > On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan, > we came to the conclusion that the max77686 and max77802 RTC are almost > the same with only a few differences so there shouldn't be two separate > drivers and is better to extend max77686 driver and delete rtc-max77802. > > By making the driver more generic, other RTC IP blocks from Maxim PMICs > could be supported as well like the max77620. > > Patches #1 is just a trivial cleanup. > > Patch #2 allows to support RTCs that need a shorter delay when updating > the RTC. > > Patch #3 adds a driver data structure to avoid hard-coding parameters > specific to a certain RTC such as the needed delay and RTC register mask. > > Patch #4 changes the driver to use a mapping table instead of using the > max77686 registers offsets directly to allow supporting RTC with other > registers addresses and layout. > > Patch #5 Adds support for max77802 to max77686 RTC driver and patch #6 > removes the old driver since is not needed anymore. > > Finally patch #7 and patch #8 removes the Kconfig symbol from defconfigs. > > I've tested this patch-set on an Exynos5800 Peach Pi Chromebook that has > a max77802 PMIC and the RTC was working correctly but I don't have a > machine with max77686 so I will really appreaciate if someone can test > that no regressions were introduced. > Thanks for the submission. I like the approach. I'll start reviewing the code and testing it... or maybe I'll wait with testing for v2 because I already sent some comments. :) Anyway I will provide later tested-by on max77686. Best regards, Krzysztof