From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757955AbcAUE6v (ORCPT ); Wed, 20 Jan 2016 23:58:51 -0500 Received: from mail-pa0-f66.google.com ([209.85.220.66]:35768 "EHLO mail-pa0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757523AbcAUE6s (ORCPT ); Wed, 20 Jan 2016 23:58:48 -0500 Subject: Re: [RFC/PATCHSET 00/17] perf tools: Add support for hierachy view (v2) To: Namhyung Kim References: <1452960197-5323-1-git-send-email-namhyung@kernel.org> <20160119205941.GG27085@kernel.org> <20160120003451.GB18796@sejong> <569F3C09.8070903@gmail.com> <20160120150819.GB23604@danjae.kornet> <569FB731.6060504@gmail.com> <20160121041757.GE10179@sejong> Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Stephane Eranian , Andi Kleen , Wang Nan , Don Zickus , Pekka Enberg , Moinuddin Quadri From: Taeung Song Message-ID: <56A06582.7000509@gmail.com> Date: Thu, 21 Jan 2016 13:58:42 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160121041757.GE10179@sejong> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Namhyung On 01/21/2016 01:17 PM, Namhyung Kim wrote: > Hi Taeung, > > On Thu, Jan 21, 2016 at 01:34:57AM +0900, Taeung Song wrote: >> On 01/21/2016 12:08 AM, Namhyung Kim wrote: >>> On Wed, Jan 20, 2016 at 04:49:29PM +0900, Taeung Song wrote: >>>> On 01/20/2016 09:34 AM, Namhyung Kim wrote: >>>>> On Tue, Jan 19, 2016 at 05:59:41PM -0300, Arnaldo Carvalho de Melo wrote: >>>>>> Ok, tested, this is really nice, I think it should be the default, from >>>>>> where to drill down, we could have a '--no-hierarchy', Ingo? >>>>> >>>>> Yeah, we already have --no-hierarchy (as a side effect of having >>>>> --hierarchy) but I don't want to change the default now since existing >>>>> users will complain. Now we have 'tips' in the perf report browser, >>>>> maybe it's enough to add a line to suggest to use it (and it's already >>>>> done by this patchset). I remember the time we changed default for >>>>> '--children' and many people complained about it. >>>>> >>>>> We maybe change the default later but I think it's better to have some >>>>> time to people can play with it and find it useful. :) And, as always, >>>>> we can have a config option to control the default. >>>> >>>> If adding this config option, >>>> can this be included in 'hist' section ? >>>> If it isn't, 'report' and 'top' section ? >>>> i.e. >>>> >>>> [report] >>>> hierarchy = true >>>> [top] >>>> hierarchy = false >>> >>> Either is fine. But as we already have report.children and >>> top.children, I'd follow the convention. Also I think we should set >>> priority of the two configs - children and hierarchy. IMHO hierarchy >>> should be considered first. >>> >>> Or maybe we could have 'report.output-default' being one of >>> 'hierarchy', 'children', or 'normal'. This way we can set the default >>> behavior easily including possible future changes. >>> >> >> Oh, IMHO I think the latter is better than the former. >> If using 'report.output-default' instead of 'report.children' >> and 'report.hierarchy' etc integrating the configs, >> it seems to be tidy. > > OK > >> Whatever this config variables will be set as, >> after this patchset are merged I'll ask about this configs, again. > > I'll add you in the CC list wrt config changes. > Thank you! Taeung