From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759194AbcAUJt7 (ORCPT ); Thu, 21 Jan 2016 04:49:59 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:38634 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbcAUJtz (ORCPT ); Thu, 21 Jan 2016 04:49:55 -0500 Subject: Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support To: Wenwei Tao References: <1452858278-30206-1-git-send-email-ww.tao0320@gmail.com> <1452858278-30206-2-git-send-email-ww.tao0320@gmail.com> <569F896F.8090606@lightnvm.io> <56A08E92.6030405@lightnvm.io> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56A0A9BF.40703@lightnvm.io> Date: Thu, 21 Jan 2016 10:49:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2016 10:47 AM, Wenwei Tao wrote: > > Currently a bitmap of luns already added into nvm_dev, every time we > map the luns we check the bitmap. > I don't quite understand why we need to add another bitmap? We can definitely use lun_map that you introduced in the patch.