From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759210AbcAUJyB (ORCPT ); Thu, 21 Jan 2016 04:54:01 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:33902 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758282AbcAUJxx (ORCPT ); Thu, 21 Jan 2016 04:53:53 -0500 Subject: Re: [RFC V2 1/2] irq: Add a framework to measure interrupt timings To: Peter Zijlstra References: <1453305636-22156-1-git-send-email-daniel.lezcano@linaro.org> <1453305636-22156-2-git-send-email-daniel.lezcano@linaro.org> <20160120192805.GT6357@twins.programming.kicks-ass.net> Cc: tglx@linutronix.de, rafael@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, nicolas.pitre@linaro.org, vincent.guittot@linaro.org From: Daniel Lezcano Message-ID: <56A0AAAE.3060609@linaro.org> Date: Thu, 21 Jan 2016 10:53:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <20160120192805.GT6357@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2016 08:28 PM, Peter Zijlstra wrote: > On Wed, Jan 20, 2016 at 05:00:32PM +0100, Daniel Lezcano wrote: >> +++ b/kernel/irq/handle.c >> @@ -165,6 +165,7 @@ irqreturn_t handle_irq_event_percpu(struct irq_desc *desc) >> /* Fall through to add to randomness */ >> case IRQ_HANDLED: >> flags |= action->flags; >> + handle_irqtiming(irq, action->dev_id); >> break; > > This also looks completely busted for shared interrupts. Hi Peter, As explained in an answer to Thomas, in case of shared interrupts, it is up to the prediction code to handle a tuple (irq, dev_id). The handler itself is at the right place IMO. -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog