From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759313AbcAUKqF (ORCPT ); Thu, 21 Jan 2016 05:46:05 -0500 Received: from smtp02.citrix.com ([66.165.176.63]:14866 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759031AbcAUKqD (ORCPT ); Thu, 21 Jan 2016 05:46:03 -0500 X-IronPort-AV: E=Sophos;i="5.22,324,1449532800"; d="scan'208";a="332988277" Subject: Re: [Xen-devel] [PATCH] cleancache: constify cleancache_ops structure To: Julia Lawall , References: <1450904784-17139-1-git-send-email-Julia.Lawall@lip6.fr> CC: , , "David Vrabel" , , "Boris Ostrovsky" From: David Vrabel Message-ID: <56A0B6E7.9040201@citrix.com> Date: Thu, 21 Jan 2016 10:45:59 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <1450904784-17139-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/12/15 21:06, Julia Lawall wrote: > The cleancache_ops structure is never modified, so declare it as const. > > This also removes the __read_mostly declaration on the cleancache_ops > variable declaration, since it seems redundant with const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > > --- > > Not sure that the __read_mostly change is correct. Does it apply to the > variable, or to what the variable points to? The variable, so... > --- a/mm/cleancache.c > +++ b/mm/cleancache.c > @@ -22,7 +22,7 @@ > * cleancache_ops is set by cleancache_register_ops to contain the pointers > * to the cleancache "backend" implementation functions. > */ > -static struct cleancache_ops *cleancache_ops __read_mostly; > +static const struct cleancache_ops *cleancache_ops; ...you want to retain the __read_mostly here. David