From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759804AbcAUPaI (ORCPT ); Thu, 21 Jan 2016 10:30:08 -0500 Received: from mail-bn1bon0072.outbound.protection.outlook.com ([157.56.111.72]:28050 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759553AbcAUPaC (ORCPT ); Thu, 21 Jan 2016 10:30:02 -0500 Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=amd.com; alien8.de; dkim=none (message not signed) header.d=none;alien8.de; dmarc=permerror action=none header.from=amd.com; X-WSS-ID: 0O1B71T-08-F82-02 X-M-MSG: Subject: Re: [patch] amd64_edac: shift wrapping issue in f1x_get_norm_dct_addr() To: Borislav Petkov , Dan Carpenter References: <20160120095451.GB19898@mwanda> <20160121123205.GE21930@pd.tnic> CC: Doug Thompson , Mauro Carvalho Chehab , , , From: Aravind Gopalakrishnan Message-ID: <56A0F973.2040906@amd.com> Date: Thu, 21 Jan 2016 09:29:55 -0600 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160121123205.GE21930@pd.tnic> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(428002)(479174004)(24454002)(377454003)(199003)(189002)(5004730100002)(97736004)(189998001)(101416001)(87936001)(33656002)(65806001)(65956001)(59896002)(87266999)(5001770100001)(86362001)(76176999)(54356999)(47776003)(83506001)(92566002)(80316001)(4001350100001)(50986999)(65816999)(23676002)(77096005)(106466001)(105586002)(2906002)(6116002)(36756003)(1220700001)(230700001)(50466002)(3846002)(1096002)(11100500001)(64126003)(586003)(5008740100001)(2950100001)(4326007);DIR:OUT;SFP:1101;SCL:1;SRVR:BN4PR12MB0852;H:atltwp02.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;2:ucprvm5jT1h6dCGvIypr/jPhtPcOnDF+0sRnliZ6Gl6uS/MRFVu4hkQONjGoA36Y7T4ihPhXD71NJ+Fu5kh/hr2c5ZBMr4+00kr2PSLwF9l3ZAz/iEBTeQx5aLuPIlDHewcInnJIiiWNYsuGykOaIQ==;3:/07OdsUpB8+NJlNEYkEF+T25gKGgMKIWIzffUHEaXD3tZjDmRf7MJBe87WmbDKGIeOQ/S9TysW7g1+ujBXLzN+cSCQDC53tDSi4XI+Sl0eDoE8AjzlYGh11rTyJM8wC39A9YPC2CJ6ywhgTaGywA2+Fi86iKXjkRxpnXP6Tc2QC+UifobOfwfCm4P6uY6KLYR53L8+xbiohhKcMNybSqppDSiE+24Di1P94qKBbmwe4=;25:DjubDb+sTZ+H1rDXH0SXtu4d95JF7m8CYyWleHtzPpFwz8yqAk5aa6W7XsucDHYBQnGOJxUXQbuU2SpLbSRF8VWJQwzi7P4UDemXQP4d9OvE3WkwlUZEsE9BUtwguT4SIIM6Hwi/04PlBnEHjY/IUz5apzEMBSt/f5vjw682V+P+plFYDl2xpo6yFWLaPBi/cdad26zvhIyd4WbLRsp6KCR99oz0LNlFCQQx9k04h55rXoQaXWHl2w7rZQlt+E0E X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-MS-Office365-Filtering-Correlation-Id: 56cec945-79e0-425d-4077-08d32277b910 X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;20:QSTmFKrqqMzpGuN5w/zk9o8lQY994zEHZiHmENH351H8TDT1JH10bMRk1obd9+H2vGFQY+d8CCLIxhxs2LkCDRJaP2y5XvK4dUPXMxyBdHawzbyNsqvyNAdq+MHOYuAS9j9iS/i6uptt433Xy93jVDpzACfkIqWYZNqf6eP5l3fS0I68D2C++rfMkYnmaLSHoY7PZPRJ+fUjBXNgBp0WoLoW402EvK3LVWFORgGsn/lac4ZP9zZTXEBvNX4A7cWo6SCZPmsQCYaytIINO+H0rQfLYf88zGzIYZrGGlkXE31gEQ62799y50VZhDt8KNPE0AG6MPh1TgsCg3J2Yp3UDcNN83zd85X8gfpABSozdWFpTVtKKhT1ixBhPCT8HvbZXaWfCpxbPPZiQrRWxp3ZDr2aUjoWXIDZO2ug9xkxxpO+yY3++VZR/Vvi2/dWVkHKcJ755FgurAcUi9y0KQaqtDfgKvl03cpKOfEwgl3fp3PXpDx/Uc1Y9k0l9yCC/1yQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(123027)(601004)(2401047)(13024025)(13017025)(13023025)(13015025)(5005006)(13018025)(520078)(8121501046)(10201501046)(3002001);SRVR:BN4PR12MB0852;BCL:0;PCL:0;RULEID:;SRVR:BN4PR12MB0852; X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;4:iK1sjtuOxH3MNMJ61TAgMB7192/2faYlNL83mIUyrZz5a7EaBVQXoeJ27iCcCTGLaEaZr0+xfuT6/cOpPGqWV3SXlG+zm9poHLBDw2UZRRTmfsxyqWuDfAfH8hIjdDXUa86zltcTTMftsMeMiwOw6EBpKL4lm/Ycorb4JopenuieG60K0RZBt5HadOY1SWnzw3+vHwcGlYegUhKViYbg7VRMbkWVH88nLThFnDV71YdJmp8j7pZ2uj4gJ7alGXfLMj8lrOYgPv02vpF1/8mAyDJ2L+nBSAZgQDsO3SumGPWtniBzj9BYBoA2c2GAjkrCTShz4xsrk+CtR5BEh0u+qdulShreRt3LeuIzib5HySp8Bg7+IIaA+7bfVD04Gm5Q9vJCE3ABPdfjoVwoBed2ST3QExQuml+DqeDLkk+rhzyeYjXeD5aId0CQceKIlW3oLIGNdeQBai440W38/RHBi+GV5B0oI5b8fNtb+DIAMHi287ZXAzR5QZX1m59nilBX X-Forefront-PRVS: 08286A0BE2 X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjRQUjEyTUIwODUyOzIzOkZHYkF0aFZvQVdjSEVjQVllcnF3UXRlSE1T?= =?utf-8?B?ZXFxZmtCZ2Z0a2I2QnBpL1hKTlBBQlNkN0lGcllnSzRHS2VOTk1TeXNBUnBZ?= =?utf-8?B?bkJpdlR5VFhrOXU3S3czdXEwVXE0TFFrMnE5NElQbEFPYnMrLzRuZ21nQlZq?= =?utf-8?B?eXUxZWgrWjVGQnJKbE9uZ1ZFZ2tEVEN5dTZ3eGhkaURtS21yeW5zbE5VTjdt?= =?utf-8?B?YlE2elU0dnhJWC9IQy9xN3hGTDhLKzd3NG5nTGswNHNJVFM3VmJPM1dZS1lF?= =?utf-8?B?TDNtU0RnK2t6R1UyUnlpSmFzRXQyOEZ0Zko2RWd0cGYrRmxpTVVHZTUxUHlX?= =?utf-8?B?aDRkQ3FaUk9QcXl4TVlURTBSa21aMnU4VDVVS25WM2ZHYzR0S0U0WkVxL1FV?= =?utf-8?B?aC9lTGxsK1pUM2xQSVRlWG8rRHhKNjBWMm5zd1o5cGVMWDNydjNydEhtMFZk?= =?utf-8?B?L2ZHV08rYnluRGxXMUpWV2NOcEQxSXNmbkJ2QVk1NXBta0dYblA3bnZjZjNM?= =?utf-8?B?Z3E2NU9Pa0xFdHhrd3lrRUV6ZjlhR3NVTWpVVTYwRldjaFhPZ0IxSUxROFlY?= =?utf-8?B?K1h6TnNUSjEzOWgyOTZwQWpxMDhqdHpXRFJ1REozUENkVlAxVmRFQXFxNjdE?= =?utf-8?B?bUczYS9iWjFVVzVWQXBrYkU2RWVtWCsrYkMxM3lnRDVDUlYwV1BneS9EM0Uz?= =?utf-8?B?ZU1wRUJtNEhKOGtHWHFiRzFqdjdtam9KajFvcnJabzhQLzY3dHV5by9OSGUz?= =?utf-8?B?ZVlDdzBoN29NY1hJWkVod0h6WTdQMHNSTWdQOEFocm1xTy9ITGhQSFJXYWZN?= =?utf-8?B?RmdFb1E5bzZzZXZlK2xrdkl0Yi9xczdaaERiUmFjZkh1dTJ6NXBHbmdpc1Rw?= =?utf-8?B?RXRtRW5zZUpJcUlHd1dXRlBlSFlQRlU5MWtZSkVNVDlvdGtUaytEL3ZweFV5?= =?utf-8?B?SXpsdWx1Wm8wVkc2bXU5VHdvNFlnV29vdkRTUnp5K0hRT3R3QldMMnNZYWdZ?= =?utf-8?B?VlVKbmM4V0RVckVKeFVwcE5UMHFWUGhPOC90d011WHlSTDBHdXZUWFFOdUZM?= =?utf-8?B?VWxRSWR3OHhjSllTeFdKcXlnendqd3ZNTHc5TWZEcHJEc2xXT0ZTVDBobkd2?= =?utf-8?B?NGZCak0wc3k2SXZSL0F2cW8wM2pZVEZaZjdwaVVyclJaamhtZ0F0R1VLTi83?= =?utf-8?B?NFJKaXJnL0NKS2REV2RORjFjbGwvUFFhVGRvenBhdkxhQ0Uvd05JaVFmd0Rk?= =?utf-8?B?bHNGSy9FcVkyVHBwL1RLc2F2V3Q4NHVqSTZVSWJlRjlrZVpLblY1QmVrWFhI?= =?utf-8?B?d0ZWcnJtU1A4T1Q1NjB1U3RncG56ZzNiNmF5M1luOWg1Y09HV2R1MGR1Si9M?= =?utf-8?B?bmdOYy95YU5IM01jUUhUTUpFWnBBdDdFRllpS1NXcXNCRHVUd3ZXQXJ3RHpT?= =?utf-8?B?S1F2clFJNTZnSjgrdGdQTE9aaXhEdThSTEk3WWRaZVBXY3BoWVIvZ3BoY0Nq?= =?utf-8?B?UUt4ZjZpOGg3TERPTE16eDlmdyt3djlsWnA3L2M1UUhVUW5CV1g5REIwVURz?= =?utf-8?B?NTVPM3pkOFNWYXNZektudk03TTdvcE5zMDREa1AyVFQrRnNscTJEYjZ4VGhm?= =?utf-8?Q?iyE8GHeh+XFXD3P3KTXt?= X-Microsoft-Exchange-Diagnostics: 1;BN4PR12MB0852;5:VX5gHJMFxRjMDB1bM/LQkttUCLAEk3WzCOZ1RsKwHCk/SG0WIefUKqU0Y4mfLObGm6+ZFy2nIreuo0ZKy5t1D3gSiMjjDTRRUPwnB9V59Ka9T7KND+/QAH21aVGhlH/sPfeIii/dYOyr8+JLKRhJmg==;24:BFXTeSAJrfAN94z8nNbK6zZg8xKQwyX4CyNHNsMhhW6yj7N+iyGpfF/Ibhl4cBco8nYNsbWLDQaI5JiN8oNV9gX8DqKoINTkgtcUgUJlC1A=;20:edo6sTYRl6vqg9L8WuAV6SFYiv9t4OoulDSbxbAGj4+arVLp/dCqXBeA+vYGWDkYUFtg71lkk5wNeGgYv0OG77qUwUIEbQaIgySsO3IzWnRQKeH9bUfGxJ/PLm93ySvPx0amrvoQ5251eet3H2HT5Dhh2pC15kihznuuuvwDZIlQWmtSZ26R3NVP+s4/aLXoKijINPgKS8Bnw5GT8h7BRAD5x3naAqRmnArN3wTdhCnZZrgEQ/IkJtIvrAsEPMOW SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2016 15:29:58.4268 (UTC) X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.222];Helo=[atltwp02.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN4PR12MB0852 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/21/2016 6:32 AM, Borislav Petkov wrote: > On Wed, Jan 20, 2016 at 12:54:51PM +0300, Dan Carpenter wrote: >> + u64 dct_sel_base_off = (u64)(pvt->dct_sel_hi & 0xFFFFFC00) << 16; > > > @Aravind: do you have a box with > > setpci -s 18.2 0x114.l > > bits [31:16] not 0? > > > Nope. I don't see it set on my Fam10h and Fam15h Model 00-0fh systems. But yes, nice catch! -Aravind.