From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965614AbcAUQCl (ORCPT ); Thu, 21 Jan 2016 11:02:41 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:35485 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965597AbcAUQCf (ORCPT ); Thu, 21 Jan 2016 11:02:35 -0500 Subject: Re: [RFC PATCH 2/2] lightnvm: add non-continuous lun target creation support To: Wenwei Tao , =?UTF-8?Q?Matias_Bj=c3=b8rling?= References: <1452858278-30206-1-git-send-email-ww.tao0320@gmail.com> <1452858278-30206-2-git-send-email-ww.tao0320@gmail.com> <569F896F.8090606@lightnvm.io> <56A08E92.6030405@lightnvm.io> <56A0A9BF.40703@lightnvm.io> Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <56A10117.2000002@bjorling.me> Date: Thu, 21 Jan 2016 17:02:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2016 02:58 PM, Wenwei Tao wrote: > 2016-01-21 17:49 GMT+08:00 Matias Bjørling : >> On 01/21/2016 10:47 AM, Wenwei Tao wrote: >> >>> >>> Currently a bitmap of luns already added into nvm_dev, every time we >>> map the luns we check the bitmap. >>> I don't quite understand why we need to add another bitmap? >> >> We can definitely use lun_map that you introduced in the patch. >> > Then I think the suggestion: > >> How about extending the functionality to take a bitmap of luns, which >> defines the luns that we like to map. Do the necessary check if any of >> them is in use, and then proceed if all is available? > > has already been implemented in this patch. Yeap :)