From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1760000AbcAUS5i (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Jan 2016 13:57:38 -0500
Received: from terminus.zytor.com ([198.137.202.10]:57395 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1759762AbcAUS5f (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Jan 2016 13:57:35 -0500
Subject: Re: [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_*
To: Borislav Petkov <bp@alien8.de>
References: <1453401286-26966-1-git-send-email-bp@alien8.de>
 <1453401286-26966-2-git-send-email-bp@alien8.de>
Cc: Andy Lutomirski <luto@amacapital.net>, Brian Gerst <brgerst@gmail.com>,
        X86 ML <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
From: "H. Peter Anvin" <hpa@zytor.com>
Message-ID: <56A12A02.60607@zytor.com>
Date: Thu, 21 Jan 2016 10:57:06 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <1453401286-26966-2-git-send-email-bp@alien8.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/21/16 10:34, Borislav Petkov wrote:
> +#ifndef _ASM_X86_REQUIRED_FEATURES_H

Why do we have all these include guards at the point of the #include?
This is not standard procedure.

	-hpa