From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@amacapital.net>,
Brian Gerst <brgerst@gmail.com>, X86 ML <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/5] x86/alternatives: Add an auxilary section
Date: Thu, 21 Jan 2016 11:10:37 -0800 [thread overview]
Message-ID: <56A12D2D.8060802@zytor.com> (raw)
In-Reply-To: <20160121190728.GH21930@pd.tnic>
On 01/21/16 11:07, Borislav Petkov wrote:
> On Thu, Jan 21, 2016 at 11:00:03AM -0800, H. Peter Anvin wrote:
>> NAK on this being part of .altinstr_replacement (if anything it ought to
>> simply be part of .text.init). Otherwise fine.
>
> You mean .init.text. Brian had it there in his original version. Out of
> curiosity, why don't you want it in .altinstr_replacement? To avoid any
> mixup?
>
We covered that already:
.altinstr_replacement doesn't need to be +X (and shouldn't be, but
that's another patch.)
.altinstr_replacement is also "special" in that all the instructions are
offset and not run in place. These are just plain code stubs and are
executed in place, as is. The only reason to have a special section for
these at all is to avoid the "init code referenced from non-init-code"
warning.
-hpa
next prev parent reply other threads:[~2016-01-21 19:11 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 18:34 [RFC PATCH 0/5] x86/cpufeature: Cleanups and improvements Borislav Petkov
2016-01-21 18:34 ` [PATCH 1/5] x86/cpufeature: Carve out X86_FEATURE_* Borislav Petkov
2016-01-21 18:57 ` H. Peter Anvin
2016-01-21 19:03 ` Borislav Petkov
2016-01-22 11:19 ` Borislav Petkov
2016-02-03 14:36 ` David Howells
2016-01-21 18:34 ` [PATCH 2/5] x86/cpufeature: Remove static_cpu_has() Borislav Petkov
2016-01-21 19:04 ` Andy Lutomirski
2016-01-21 19:39 ` Borislav Petkov
2016-01-21 19:41 ` H. Peter Anvin
2016-01-21 19:51 ` Borislav Petkov
2016-01-21 19:05 ` H. Peter Anvin
2016-01-21 18:34 ` [PATCH 3/5] x86/cpufeature: Get rid of the non-asm goto variant Borislav Petkov
2016-01-21 18:59 ` H. Peter Anvin
2016-01-21 18:34 ` [PATCH 4/5] x86/alternatives: Add an auxilary section Borislav Petkov
2016-01-21 19:00 ` H. Peter Anvin
2016-01-21 19:07 ` Borislav Petkov
2016-01-21 19:10 ` H. Peter Anvin [this message]
2016-01-21 18:34 ` [PATCH 5/5] x86/alternatives: Discard dynamic check after init Borislav Petkov
2016-01-21 19:03 ` H. Peter Anvin
2016-01-21 21:53 ` [RFC PATCH 0/5] x86/cpufeature: Cleanups and improvements Brian Gerst
2016-01-21 22:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A12D2D.8060802@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox