From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760062AbcAUTLI (ORCPT ); Thu, 21 Jan 2016 14:11:08 -0500 Received: from terminus.zytor.com ([198.137.202.10]:57612 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759637AbcAUTLG (ORCPT ); Thu, 21 Jan 2016 14:11:06 -0500 Subject: Re: [PATCH 4/5] x86/alternatives: Add an auxilary section To: Borislav Petkov References: <1453401286-26966-1-git-send-email-bp@alien8.de> <1453401286-26966-5-git-send-email-bp@alien8.de> <56A12AB3.90607@zytor.com> <20160121190728.GH21930@pd.tnic> Cc: Andy Lutomirski , Brian Gerst , X86 ML , LKML From: "H. Peter Anvin" Message-ID: <56A12D2D.8060802@zytor.com> Date: Thu, 21 Jan 2016 11:10:37 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160121190728.GH21930@pd.tnic> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/16 11:07, Borislav Petkov wrote: > On Thu, Jan 21, 2016 at 11:00:03AM -0800, H. Peter Anvin wrote: >> NAK on this being part of .altinstr_replacement (if anything it ought to >> simply be part of .text.init). Otherwise fine. > > You mean .init.text. Brian had it there in his original version. Out of > curiosity, why don't you want it in .altinstr_replacement? To avoid any > mixup? > We covered that already: .altinstr_replacement doesn't need to be +X (and shouldn't be, but that's another patch.) .altinstr_replacement is also "special" in that all the instructions are offset and not run in place. These are just plain code stubs and are executed in place, as is. The only reason to have a special section for these at all is to avoid the "init code referenced from non-init-code" warning. -hpa