From: "H. Peter Anvin" <hpa@zytor.com>
To: William Breathitt Gray <vilhelm.gray@gmail.com>,
tglx@linutronix.de, mingo@redhat.com
Cc: gregkh@linuxfoundation.org, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] base: isa: Remove X86_32 dependency
Date: Thu, 21 Jan 2016 15:47:04 -0800 [thread overview]
Message-ID: <56A16DF8.5000900@zytor.com> (raw)
In-Reply-To: <56A16D28.3010205@gmail.com>
On 01/21/16 15:43, William Breathitt Gray wrote:
> On 01/21/2016 02:40 PM, H. Peter Anvin wrote:
>> CONFIG_ISA is mainly used to exclude drivers that are for ISA-specific
>> devices.
>>
>> However, PC/104 is indeed an actual ISA parallel bus, and as you say
>> widely used in embedded systems. However, I would like to see if there
>> are anything hidden with !CONFIG_ISA which makes sense in PC104 systems.
>
> My ultimate objective is to be able to use the ISA bus driver
> (drivers/base/isa.c). This driver is conditionally compiled based on
> CONFIG_ISA, which in turn depends on CONFIG_X86_32. Up until now, I've
> been using platform_driver for my non-hotpluggable PC/104 devices, but
> it appears that isa_driver is more appropriate; unfortunately, I have
> CONFIG_X86_64 set, which prevents the compilation of drivers/base/isa.c
> due to the CONFIG_X86_32 dependency.
>
> I can alternatively create a patch to introduce a CONFIG_PC104 option.
> This would allow the compilation of the ISA bus driver on either
> CONFIG_ISA or CONFIG_PC104, thus allowing CONFIG_ISA to remain dependent
> on CONFIG_X86_32. However, if the CONFIG_X86_32 dependency was
> arbitrarily added to simply hide ISA functionality from newer
> motherboards, perhaps the dependency should be removed.
>
Well, and as you can see from the build robot because a lot of those
drivers simply don't compile on 64-bit systems. If nothing else you
would have to push the 32-bit tests downward in the config dependency tree.
-hpa
next prev parent reply other threads:[~2016-01-21 23:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 15:56 [PATCH] base: isa: Remove X86_32 dependency William Breathitt Gray
2016-01-21 19:40 ` H. Peter Anvin
2016-01-21 23:43 ` William Breathitt Gray
2016-01-21 23:47 ` H. Peter Anvin [this message]
2016-01-22 0:01 ` William Breathitt Gray
2016-01-22 8:07 ` Thomas Gleixner
2016-01-21 21:18 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A16DF8.5000900@zytor.com \
--to=hpa@zytor.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vilhelm.gray@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).