From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751171AbcAUXrY (ORCPT ); Thu, 21 Jan 2016 18:47:24 -0500 Received: from terminus.zytor.com ([198.137.202.10]:33647 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbcAUXrW (ORCPT ); Thu, 21 Jan 2016 18:47:22 -0500 Subject: Re: [PATCH] base: isa: Remove X86_32 dependency To: William Breathitt Gray , tglx@linutronix.de, mingo@redhat.com References: <20160121155617.GA20054@sophia> <56A1341B.3010702@zytor.com> <56A16D28.3010205@gmail.com> Cc: gregkh@linuxfoundation.org, x86@kernel.org, linux-kernel@vger.kernel.org From: "H. Peter Anvin" Message-ID: <56A16DF8.5000900@zytor.com> Date: Thu, 21 Jan 2016 15:47:04 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <56A16D28.3010205@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/16 15:43, William Breathitt Gray wrote: > On 01/21/2016 02:40 PM, H. Peter Anvin wrote: >> CONFIG_ISA is mainly used to exclude drivers that are for ISA-specific >> devices. >> >> However, PC/104 is indeed an actual ISA parallel bus, and as you say >> widely used in embedded systems. However, I would like to see if there >> are anything hidden with !CONFIG_ISA which makes sense in PC104 systems. > > My ultimate objective is to be able to use the ISA bus driver > (drivers/base/isa.c). This driver is conditionally compiled based on > CONFIG_ISA, which in turn depends on CONFIG_X86_32. Up until now, I've > been using platform_driver for my non-hotpluggable PC/104 devices, but > it appears that isa_driver is more appropriate; unfortunately, I have > CONFIG_X86_64 set, which prevents the compilation of drivers/base/isa.c > due to the CONFIG_X86_32 dependency. > > I can alternatively create a patch to introduce a CONFIG_PC104 option. > This would allow the compilation of the ISA bus driver on either > CONFIG_ISA or CONFIG_PC104, thus allowing CONFIG_ISA to remain dependent > on CONFIG_X86_32. However, if the CONFIG_X86_32 dependency was > arbitrarily added to simply hide ISA functionality from newer > motherboards, perhaps the dependency should be removed. > Well, and as you can see from the build robot because a lot of those drivers simply don't compile on 64-bit systems. If nothing else you would have to push the 32-bit tests downward in the config dependency tree. -hpa