From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751536AbcAVAvs (ORCPT ); Thu, 21 Jan 2016 19:51:48 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:23312 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750726AbcAVAvn (ORCPT ); Thu, 21 Jan 2016 19:51:43 -0500 X-AuditID: cbfec7f5-f79b16d000005389-90-56a17d1c34fd Subject: Re: [PATCH v2 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-2-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56A17D1F.5030802@samsung.com> Date: Fri, 22 Jan 2016 09:51:43 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453407813-14646-2-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xy7oytQvDDPqaFSw6ri1msrj+5Tmr xZu3a5gsXr8wtOh//JrZYum+1SwWl3fNYbOYcX4fk8X+zg5GB06PJ5suMnrsmXiSzWPTqk42 j97md2weW/rvsnv0bVnF6PF5k1wAexSXTUpqTmZZapG+XQJXxsKdM1gKznNUfL55k6mBcSJ7 FyMHh4SAicT1awZdjJxAppjEhXvr2boYuTiEBJYySsz89JMFwnnKKPH71GOwBmGBSIlZLTUg DSICoRL/Lt5mBLGFBJqBau6qgtjMAu8YJSbssQWx2QSMJTYvX8IGsUBOord7EguIzSugJdEw ZTsziM0ioCpxe/9fsLioQITE4c4udogaQYkfk++BxTkF3CUO7JvBAnICs4CexP2LWhCr5CU2 r3nLPIFRcBaSjlkIVbOQVC1gZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERIdX3cwLj1m dYhRgINRiYeXQ3dhmBBrYllxZe4hRgkOZiUR3q3VQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8 M3e9DxESSE8sSc1OTS1ILYLJMnFwSjUwzp46addHZm2Gw5r307svG6x9cyrv26XLArZt12X5 rlXt7lWfKfVhEnf7MtajX1/Obn0vKt6z94DvhuRrT1iijlc9WMcp8tnlkd3/6Q1SvcE1xe94 olXYV9efPFS3oGelt2e1fORpzyuaCSL5HuHuFqvvNBafUBJ9ZWy0xJXtyHMDPcFADY3dSizF GYmGWsxFxYkA7yUA3YoCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.01.2016 05:23, Javier Martinez Canillas wrote: > The function is always returning zero even in case of failures since > the ret value was not propagated to the callers. Fix the error path. > > Reported-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > --- > > Changes in v2: None > > drivers/rtc/rtc-max77686.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-max77686.c b/drivers/rtc/rtc-max77686.c > index 7184a0eda793..6653c3d11b66 100644 > --- a/drivers/rtc/rtc-max77686.c > +++ b/drivers/rtc/rtc-max77686.c > @@ -235,7 +235,7 @@ static int max77686_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm) > > out: > mutex_unlock(&info->lock); > - return 0; > + return ret; > } > > static int max77686_rtc_stop_alarm(struct max77686_rtc_info *info) Reviewed-by: Krzysztof Kozlowski Tested on Trats2 board with max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof