From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751449AbcAVBCV (ORCPT ); Thu, 21 Jan 2016 20:02:21 -0500 Received: from mailout4.w1.samsung.com ([210.118.77.14]:64952 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbcAVBCR (ORCPT ); Thu, 21 Jan 2016 20:02:17 -0500 X-AuditID: cbfec7f5-f79b16d000005389-47-56a17f96e9d5 Subject: Re: [PATCH v2 03/10] rtc: max77686: Use usleep_range() instead of msleep() To: Javier Martinez Canillas , linux-kernel@vger.kernel.org References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-4-git-send-email-javier@osg.samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <56A17F99.6080903@samsung.com> Date: Fri, 22 Jan 2016 10:02:17 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <1453407813-14646-4-git-send-email-javier@osg.samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xq7rT6heGGRw4xWPRcW0xk8X1L89Z Ld68XcNk8fqFoUX/49fMFkv3rWaxuLxrDpvFjPP7mCz2d3YwOnB6PNl0kdFjz8STbB6bVnWy efQ2v2Pz2NJ/l92jb8sqRo/Pm+QC2KO4bFJSczLLUov07RK4Mq60zGMrWMpR8arvE1MD4y22 LkZODgkBE4m2ZxuYIWwxiQv31oPFhQSWMkpMe83ZxcgFZD9llHjW8A8owcEhLBAq8WOyP0iN CJD57+JtRoiaZkaJjq63LCAJZoF3jBIT9tiC2GwCxhKbly+BWiYn0ds9iQVkDq+AlsTTd2Eg YRYBVYmrF7rASkQFIiQOd3axg9i8AoJAq+6BjeQUcJfoeHCOGaSVWUBP4v5FLYhN8hKb17xl nsAoOAtJxyyEqllIqhYwMq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECImOrzsYlx6zOsQo wMGoxMPLobswTIg1say4MvcQowQHs5II79ZqoBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembve hwgJpCeWpGanphakFsFkmTg4pRoYi5ZaXdk8cfPGNRy/zjY8NH+/dXXWg0LvMp/P23a/mPT9 2f9HLUEy066f/M637smU8+z7bSa6yM/LiDyk6iIyZ6vx1I1imcvcts1caaq42XTei/+XHn3L vnDlUe0t8c3nhV5Pnntd2PKCVFuRVlzYihKeiDWibMdYjx1pytebtWMdy6n6QtaPc0WVWIoz Eg21mIuKEwFigMDAigIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22.01.2016 05:23, Javier Martinez Canillas wrote: > Documentation/timers/timers-howto.txt suggest to use usleep_range() > instead of msleep() for small msec (1ms - 20ms) since msleep() will > often sleep for 20ms for any value in that range. > > This is fine in this case since 16ms is the _minimum_ delay required > by max77686 for an RTC update but by using usleep_range() instead of > msleep(), the driver can support other RTC IP blocks with a shorter > minimum delay (i.e: in the range of usecs instead of msecs). > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > > --- > > Changes in v2: > - Add Krzysztof Kozlowski's Reviewed-by tag to patch #3. > - Fix typo error in changelog. Suggested by Krzysztof Kozlowski. > > drivers/rtc/rtc-max77686.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > Tested on Trats2 board with max77686: Tested-by: Krzysztof Kozlowski Best regards, Krzysztof