From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751333AbcAVBIL (ORCPT ); Thu, 21 Jan 2016 20:08:11 -0500 Received: from regular1.263xmail.com ([211.150.99.135]:52816 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751003AbcAVBHw (ORCPT ); Thu, 21 Jan 2016 20:07:52 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56A180E0.6090601@rock-chips.com> Date: Fri, 22 Jan 2016 09:07:44 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: John Keeping , Daniel Vetter CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] drm/rockchip: respect CONFIG_DRM_FBDEV_EMULATION References: <1453384426-32617-1-git-send-email-john@metanate.com> <20160121165251.GO19130@phenom.ffwll.local> <20160121181934.76cb2c03.john@metanate.com> In-Reply-To: <20160121181934.76cb2c03.john@metanate.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年01月22日 02:19, John Keeping wrote: > If DRM_FBDEV_EMULATION is not selected in the config then we can save a > bit of space by not including the framebuffer code. > > Signed-off-by: John Keeping > --- > On Thu, 21 Jan 2016 17:52:51 +0100, Daniel Vetter wrote: > >> On Thu, Jan 21, 2016 at 01:53:46PM +0000, John Keeping wrote: >>> If DRM_FBDEV_EMULATION is not selected in the config then we should not >>> setup a framebuffer console. >> It should just magically work, and this patch here just removes a bit more >> dead code in the rockchip driver itself that's not needed in case fbdev >> emulation is disabled. >> >> Can you please double-check this is the case and then resend with a >> clarified commit message? > You're right, it does work without this change, so this is just to save > a bit of space when we don't need this feature. > > v2: > - change commit message to clarify that this is only to remove some dead > code > > drivers/gpu/drm/rockchip/Makefile | 3 ++- > drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h | 11 +++++++++++ > 2 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/Makefile b/drivers/gpu/drm/rockchip/Makefile > index a4e03bc..f6a809a 100644 > --- a/drivers/gpu/drm/rockchip/Makefile > +++ b/drivers/gpu/drm/rockchip/Makefile > @@ -2,8 +2,9 @@ > # Makefile for the drm device driver. This driver provides support for the > # Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > -rockchipdrm-y := rockchip_drm_drv.o rockchip_drm_fb.o rockchip_drm_fbdev.o \ > +rockchipdrm-y := rockchip_drm_drv.o rockchip_drm_fb.o \ > rockchip_drm_gem.o rockchip_drm_vop.o > +rockchipdrm-$(CONFIG_DRM_FBDEV_EMULATION) += rockchip_drm_fbdev.o > > obj-$(CONFIG_ROCKCHIP_DW_HDMI) += dw_hdmi-rockchip.o > obj-$(CONFIG_ROCKCHIP_DW_MIPI_DSI) += dw-mipi-dsi.o > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h > index 50432e9..73718c5 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_fbdev.h > @@ -15,7 +15,18 @@ > #ifndef _ROCKCHIP_DRM_FBDEV_H > #define _ROCKCHIP_DRM_FBDEV_H > > +#ifdef CONFIG_DRM_FBDEV_EMULATION > int rockchip_drm_fbdev_init(struct drm_device *dev); > void rockchip_drm_fbdev_fini(struct drm_device *dev); > +#else > +static inline int rockchip_drm_fbdev_init(struct drm_device *dev) > +{ > + return 0; > +} > + > +static inline void rockchip_drm_fbdev_fini(struct drm_device *dev) > +{ > +} > +#endif > > #endif /* _ROCKCHIP_DRM_FBDEV_H */ Looks good and it works on my popmetal board. Applied to my branch:-) . -- Ｍark Yao