From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751744AbcAVGGG (ORCPT ); Fri, 22 Jan 2016 01:06:06 -0500 Received: from e17.ny.us.ibm.com ([129.33.205.207]:57819 "EHLO e17.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbcAVGF7 (ORCPT ); Fri, 22 Jan 2016 01:05:59 -0500 X-IBM-Helo: d01dlp03.pok.ibm.com X-IBM-MailFrom: ravi.bangoria@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH] perf/kvm: Guest Symbol Resolution for powerpc To: Arnaldo Carvalho de Melo References: <1451383720-7647-1-git-send-email-ravi.bangoria@linux.vnet.ibm.com> <20160113165936.GP18367@kernel.org> Cc: linux-kernel@vger.kernel.org, hemant@linux.vnet.ibm.com, naveen.n.rao@linux.vnet.ibm.com, Ingo Molnar , Peter Zijlstra From: Ravi Bangoria Message-ID: <56A1C6BF.2010602@linux.vnet.ibm.com> Date: Fri, 22 Jan 2016 11:35:51 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160113165936.GP18367@kernel.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012206-0041-0000-0000-000003168D59 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnaldo, On Wednesday 13 January 2016 10:29 PM, Arnaldo Carvalho de Melo wrote: > Em Tue, Dec 29, 2015 at 03:38:40PM +0530, Ravi Bangoria escreveu: >> 'perf kvm {record|report}' is used to record and report the profiled >> performance of any workload on a guest. From the host, we can collect >> guest kernel statistics which is useful in finding out any contentions >> in guest kernel symbols for a certain workload. >> This feature is not available on powerpc because 'perf' relies on the >> 'cycles' event (a PMU event) to profile the guest. However, for powerpc, >> this can't be used from the host because the PMUs are controlled by the >> guest rather than the host. > Without entering the realms if the approach is the right one, which I > leave to PowerPC experts, Ingo, PeterZ, etc: > > So, in these cases, please break this into a series, where you, for > instance, will add that extra evsel parameter to the functions that will > ultimately use it to extract those event fields, that should be a > separate patch, so that when reviewing the "meat" of your patch we can > quickly see what it does, not having to extract that from leg work. > > Two other patches should introduce arch__get_{ip,cpumode}(). > > - Arnaldo Thanks for suggestion. I've sent v2 with changes you suggested. Can you please take a look. Regards, Ravi