From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753071AbcAVJqn (ORCPT ); Fri, 22 Jan 2016 04:46:43 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:9670 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752914AbcAVJqi (ORCPT ); Fri, 22 Jan 2016 04:46:38 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Fri, 22 Jan 2016 01:47:50 -0800 Message-ID: <56A1F7F9.40603@nvidia.com> Date: Fri, 22 Jan 2016 15:05:53 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Javier Martinez Canillas , CC: Kukjin Kim , , Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Subject: Re: [PATCH v2 01/10] rtc: max77686: Fix max77686_rtc_read_alarm() return value References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-2-git-send-email-javier@osg.samsung.com> In-Reply-To: <1453407813-14646-2-git-send-email-javier@osg.samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: > The function is always returning zero even in case of failures since > the ret value was not propagated to the callers. Fix the error path. > > Reported-by: Krzysztof Kozlowski > Signed-off-by: Javier Martinez Canillas > --- > Acked-by: Laxman Dewangan