From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753335AbcAVLuT (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Jan 2016 06:50:19 -0500
Received: from hqemgate15.nvidia.com ([216.228.121.64]:2927 "EHLO
	hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752733AbcAVLuJ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Jan 2016 06:50:09 -0500
X-PGP-Universal: processed;
	by hqnvupgp08.nvidia.com on Fri, 22 Jan 2016 03:51:15 -0800
Message-ID: <56A214EB.30905@nvidia.com>
Date: Fri, 22 Jan 2016 17:09:23 +0530
From: Laxman Dewangan <ldewangan@nvidia.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>, <robh+dt@kernel.org>,
        <pawel.moll@arm.com>, <mark.rutland@arm.com>,
        <ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
        <linus.walleij@linaro.org>, <gnurou@gmail.com>, <lee.jones@linaro.org>,
        <broonie@kernel.org>, <a.zummo@towertech.it>,
        <alexandre.belloni@free-electrons.com>
CC: <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <rtc-linux@googlegroups.com>, <swarren@nvidia.com>,
        <treding@nvidia.com>, <vreddytalla@nvidia.com>,
        Chaitanya Bandi <bandik@nvidia.com>,
        Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024
References: <1453198783-28383-1-git-send-email-ldewangan@nvidia.com> <1453198783-28383-3-git-send-email-ldewangan@nvidia.com> <569F199D.9020207@samsung.com>
In-Reply-To: <569F199D.9020207@samsung.com>
X-Originating-IP: [10.19.65.30]
X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To
 bgmail102.nvidia.com (10.25.59.11)
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks Krzysztof for review.

Hi Lee,
Are you taking the patches from your tree? Or will go in individual 
subsystem?

Thanks,
Laxman


On Wednesday 20 January 2016 10:52 AM, Krzysztof Kozlowski wrote:
> On 19.01.2016 19:19, Laxman Dewangan wrote:
>> MAX77620/MAX20024 are Power Management IC from the MAXIM.
>> It supports RTC, multiple GPIOs, multiple DCDC and LDOs,
>> watchdog, clock etc.
>>
>> Add MFD drier to provides common support for accessing the
>> device; additional drivers is developed on respected subsystem
>> in order to use the functionality of the device.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Signed-off-by: Chaitanya Bandi <bandik@nvidia.com>
>> Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
>> ---
>> Changes from V1:
>> - Code cleanups per review from V1.
>> - Move register acccess APIs from header to c file.
>> - Remove some of non required variable, remove duplication in error message
>>   and simplify some of function implementation.
>> - Register RTC driver such that it can get the regmap handle form parent device
>>
>> Changes from V2:
>> - Run coccicheck and checkpatch in strict mode for the alignment.
>> - Drop RTC driver and its i2c client registration.
>>
>> Changes from V3:
>> - Change all sys initcall to module driver.
>> - change the max77620_read argument to unisgned int from u8.
>>
>>   drivers/mfd/Kconfig          |  15 +
>>   drivers/mfd/Makefile         |   1 +
>>   drivers/mfd/max77620.c       | 871 +++++++++++++++++++++++++++++++++++++++++++
>>   include/linux/mfd/max77620.h | 404 ++++++++++++++++++++
>>   4 files changed, 1291 insertions(+)
>>   create mode 100644 drivers/mfd/max77620.c
>>   create mode 100644 include/linux/mfd/max77620.h
>>
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof
>