From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754128AbcAVP6U (ORCPT <rfc822;w@1wt.eu>);
	Fri, 22 Jan 2016 10:58:20 -0500
Received: from mail1.bemta12.messagelabs.com ([216.82.251.7]:32339 "EHLO
	mail1.bemta12.messagelabs.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754050AbcAVP6Q (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 22 Jan 2016 10:58:16 -0500
X-Env-Sender: Marc_Gonzalez@sigmadesigns.com
X-Msg-Ref: server-10.tower-163.messagelabs.com!1453478289!23383904!1
X-Originating-IP: [195.215.56.170]
X-StarScan-Received: 
X-StarScan-Version: 7.35.1; banners=-,-,-
X-VirusChecked: Checked
Subject: Re: [RFC PATCH v3] irqchip: Add support for Tango interrupt
 controller
To: Mans Rullgard <mans@mansr.com>
CC: Marc Zyngier <marc.zyngier@arm.com>, Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        Sebastian Frias <sf84@laposte.net>
References: <569CE0F2.1060507@sigmadesigns.com>
 <569D0B80.1010908@sigmadesigns.com> <569D165E.4060004@sigmadesigns.com>
 <569FAFF5.4090909@arm.com> <yw1xr3hcqlix.fsf@unicorn.mansr.com>
 <569FB471.8000909@arm.com> <yw1xmvs0qkue.fsf@unicorn.mansr.com>
 <569FB7A9.9080309@sigmadesigns.com> <yw1xegdcqk8n.fsf@unicorn.mansr.com>
 <569FB91D.9030704@sigmadesigns.com> <yw1x1t9cqg18.fsf@unicorn.mansr.com>
From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Message-ID: <56A2518F.6060808@sigmadesigns.com>
Date: Fri, 22 Jan 2016 16:58:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:42.0) Gecko/20100101
 Firefox/42.0 SeaMonkey/2.39
MIME-Version: 1.0
In-Reply-To: <yw1x1t9cqg18.fsf@unicorn.mansr.com>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [172.27.0.114]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/01/2016 19:09, Måns Rullgård wrote:

> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
> 
>> On 20/01/2016 17:38, Måns Rullgård wrote:
>>
>>> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
>>>
>>>> On 20/01/2016 17:25, Måns Rullgård wrote:
>>>>
>>>>> Marc Zyngier <marc.zyngier@arm.com> writes:
>>>>>
>>>>>> On 20/01/16 16:10, Måns Rullgård wrote:
>>>>>>
>>>>>>> Marc Zyngier <marc.zyngier@arm.com> writes:
>>>>>>>
>>>>>>>>> +	if (of_property_read_u32(node, "reg", &ctl))
>>>>>>>>> +		panic("%s: failed to get reg base", node->name);
>>>>>>>>> +
>>>>>>>>> +	chip = kzalloc(sizeof(*chip), GFP_KERNEL);
>>>>>>>>> +	chip->ctl = ctl;
>>>>>>>>> +	chip->base = base;
>>>>>>>
>>>>>>> As I said before, this assumes the outer DT node uses a ranges
>>>>>>> property.  Normally reg properties work the same whether they specify an
>>>>>>> offset within an outer "ranges" or have a full address directly.  It
>>>>>>> would be easy enough to make this work with either, so I don't see any
>>>>>>> reason not to.
>>>>>>
>>>>>> Yup, that is a good point. I guess Marc can address this in the next
>>>>>> round, since we need a DT binding anyway.
>>>>>
>>>>> I'd suggest using of_address_to_resource() on both nodes and subtracting
>>>>> the start addresses returned.
>>>>
>>>> For my own reference, Marc Zyngier suggested:
>>>> "you should use of_iomap to map the child nodes, and not mess with
>>>> the parent one."
>>>
>>> That's going to get very messy since the generic irqchip code needs all
>>> the registers as offsets from a common base address.
>>
>> The two suggestions are over my head at the moment.
>>
>> Do you want to submit v4 and have Marc Z take a look?
> 
> Done.  If this isn't acceptable either, I'm out of ideas that don't end
> up being far uglier than anything suggested so far.

With your latest patch, can I drop the ranges property?

Regards.