From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050AbcAVQb2 (ORCPT ); Fri, 22 Jan 2016 11:31:28 -0500 Received: from mail-pa0-f51.google.com ([209.85.220.51]:32816 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753191AbcAVQbY (ORCPT ); Fri, 22 Jan 2016 11:31:24 -0500 Subject: Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic transfers To: John Ogness , gregkh@linuxfoundation.org, vinod.koul@intel.com References: <87zivxq57d.fsf@linutronix.de> Cc: dan.j.williams@intel.com, bigeasy@linutronix.de, tony@atomide.com, nsekhar@ti.com, peter.ujfalusi@ti.com, dmaengine@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org From: Peter Hurley Message-ID: <56A25959.4060802@hurleysoftware.com> Date: Fri, 22 Jan 2016 08:31:21 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <87zivxq57d.fsf@linutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, On 01/22/2016 02:27 AM, John Ogness wrote: > Note that an ugly device-tree lookup hack is implemented in order > to detect if the sDMA engine is being used. This is necessary > because the sDMA driver does not implement pause/resume correctly > and therefore requires slightly different logic for the UART > driver. No, this is not acceptable. Please work with Vinod to refine the dma_get_slave_caps() interface so that dmaengine drivers that don't provide the _documented_ pause/resume support can be identified generically. Regards, Peter Hurley