From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755045AbcAVSjW (ORCPT ); Fri, 22 Jan 2016 13:39:22 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:38630 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754932AbcAVSjE (ORCPT ); Fri, 22 Jan 2016 13:39:04 -0500 Subject: Re: [PATCH V12 3/7] dma: add Qualcomm Technologies HIDMA management driver To: Mark Rutland References: <1452523550-8920-1-git-send-email-okaya@codeaurora.org> <1452523550-8920-4-git-send-email-okaya@codeaurora.org> <20160115145629.GI3262@leverpostej> <56990C40.4050407@codeaurora.org> <20160115152257.GK3262@leverpostej> Cc: dmaengine@vger.kernel.org, timur@codeaurora.org, devicetree@vger.kernel.org, cov@codeaurora.org, vinod.koul@intel.com, jcm@redhat.com, agross@codeaurora.org, arnd@arndb.de, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, christoffer.dall@linaro.org, shankerd@codeaurora.org, Vikram Sethi From: Sinan Kaya Message-ID: <56A27743.40008@codeaurora.org> Date: Fri, 22 Jan 2016 13:38:59 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160115152257.GK3262@leverpostej> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/15/2016 10:22 AM, Mark Rutland wrote: > Typically VFIO-platform also comes with a corresponding reset driver. > You don't need one? Digging this further, I do need a HIDMA reset driver. The reset driver is useful if HIDMA operation is aborted in the middle and guest machine is shutdown. I'm preparing a reset driver and I'll post it soon. In the meantime, I have observed a lack of ACPI HID support in the platform reset interface vfio_platform_lookup_reset and vfio_platform_probe_common specifically. The interface is querying objects with "compatible" string. Of course on a true ACPI system with proper named HIDs except PRP001, "compatible" attribute does not exist. I'm also preparing a patch for this too. Since VFIO patches go through another branch and the reset driver also needs to go through vfio along with the ACPI object querying support, would you like this to be addressed independently with a different series or have it reviewed altogether here then figure out the merge path later? -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project