From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753393AbcAWPFw (ORCPT ); Sat, 23 Jan 2016 10:05:52 -0500 Received: from goliath.siemens.de ([192.35.17.28]:35231 "EHLO goliath.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbcAWPFu (ORCPT ); Sat, 23 Jan 2016 10:05:50 -0500 Subject: Re: [PATCH 1/5] scripts/gdb: Provide linux constants To: Kieran Bingham References: <1453288550-4706-1-git-send-email-kieran.bingham@linaro.org> <1453288550-4706-2-git-send-email-kieran.bingham@linaro.org> Cc: linux-kernel@vger.kernel.org, maxime.coquelin@st.com, peter.griffin@linaro.org, lee.jones@linaro.org From: Jan Kiszka Message-ID: <56A396C8.3040202@siemens.com> Date: Sat, 23 Jan 2016 16:05:44 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1453288550-4706-2-git-send-email-kieran.bingham@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-01-20 12:15, Kieran Bingham wrote: > Some macro's and defines are needed when parsing memory, and without > compiling the kernel as -g3 they are not available in the debug-symbols. > > We use the pre-processor here to extract constants to a dedicated module > for the linux debugger extensions > > Signed-off-by: Kieran Bingham > --- > > I've added a 'constants.py' which is automatically generated. This allows > values not available to the debugger, through #defines to be provided to > our scripts. > > The alternative method for this is to create a c-object file to obtain values > through symbols instead, and compile segments with -g3 to include macro > definitions in the debug-info. > > I'd appreciate your thoughts on these options. I cannot assess your second proposal. How invasive will it be? Is it promising to reduce the maintenance? What will be the impact of -g3? This approach seems pragmatic and sufficient. Would be fine with me unless the other has significant advantages. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux