From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753365AbcAWPMv (ORCPT <rfc822;w@1wt.eu>);
	Sat, 23 Jan 2016 10:12:51 -0500
Received: from thoth.sbs.de ([192.35.17.2]:42767 "EHLO thoth.sbs.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752538AbcAWPMt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 Jan 2016 10:12:49 -0500
Subject: Re: [PATCH 3/5] scripts/gdb: Add io resource readers
To: Kieran Bingham <kieran.bingham@linaro.org>
References: <1453288550-4706-1-git-send-email-kieran.bingham@linaro.org>
 <1453288550-4706-4-git-send-email-kieran.bingham@linaro.org>
Cc: linux-kernel@vger.kernel.org, maxime.coquelin@st.com,
        peter.griffin@linaro.org, lee.jones@linaro.org
From: Jan Kiszka <jan.kiszka@siemens.com>
Message-ID: <56A39841.4040901@siemens.com>
Date: Sat, 23 Jan 2016 16:12:01 +0100
User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12)
 Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666
MIME-Version: 1.0
In-Reply-To: <1453288550-4706-4-git-send-email-kieran.bingham@linaro.org>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016-01-20 12:15, Kieran Bingham wrote:
> Provide iomem_resource and ioports_resource printers and command hooks
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@linaro.org>
> 
> ---
> 
> These two readers are a useful extract of kernel information.
> This shows the power of having these commands in gdb/scripts as you can
> halt a kernel as it's booting and read these as the structures grow.
> 
> It should be useful in the event that a kernel is not booting, you
> can identify what memory resources have been registered
> 

Ack. Maybe provide this reasoning in the commit log? I explains why we
want this which is too often lacking in the persistent logs...

> 
> 
>  scripts/gdb/linux/proc.py | 57 +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 57 insertions(+)
> 
> diff --git a/scripts/gdb/linux/proc.py b/scripts/gdb/linux/proc.py
> index 6e6709c1830c..d855b2fd9a06 100644
> --- a/scripts/gdb/linux/proc.py
> +++ b/scripts/gdb/linux/proc.py
> @@ -39,3 +39,60 @@ class LxVersion(gdb.Command):
>          gdb.write(gdb.parse_and_eval("linux_banner").string())
>  
>  LxVersion()
> +
> +
> +# Resource Structure Printers
> +#  /proc/iomem
> +#  /proc/ioports
> +
> +def get_resources(resource, depth):
> +    while resource:
> +        yield resource, depth
> +
> +        child = resource['child']
> +        if child:
> +            for res, deep in get_resources(child, depth + 1):
> +                yield res, deep
> +
> +        resource = resource['sibling']
> +
> +
> +def show_lx_resources(resource_str):
> +        resource = gdb.parse_and_eval(resource_str)
> +        width = 4 if resource['end'] < 0x10000 else 8
> +        # Iterate straight to the first child
> +        for res, depth in get_resources(resource['child'], 0):
> +            start = int(res['start'])
> +            end = int(res['end'])
> +            gdb.write(" " * depth * 2 +
> +                      "{0:0{1}x}-".format(start, width) +
> +                      "{0:0{1}x} : ".format(end, width) +
> +                      res['name'].string() + "\n")
> +
> +
> +class LxIOMem(gdb.Command):
> +    """Identify the IO memory resource locations defined by the kernel
> +
> +Equivalent to cat /proc/iomem on a running target"""
> +
> +    def __init__(self):
> +        super(LxIOMem, self).__init__("lx-iomem", gdb.COMMAND_DATA)
> +
> +    def invoke(self, arg, from_tty):
> +        return show_lx_resources("iomem_resource")
> +
> +LxIOMem()
> +
> +
> +class LxIOPorts(gdb.Command):
> +    """Identify the IO port resource locations defined by the kernel
> +
> +Equivalent to cat /proc/ioports on a running target"""
> +
> +    def __init__(self):
> +        super(LxIOPorts, self).__init__("lx-ioports", gdb.COMMAND_DATA)
> +
> +    def invoke(self, arg, from_tty):
> +        return show_lx_resources("ioport_resource")
> +
> +LxIOPorts()
> 

Looks good to me.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux