* [PATCH] mmc: dw_mmc: remove repetitive clear interrupt
@ 2016-01-25 1:13 Shawn Lin
2016-01-25 4:14 ` Jaehoon Chung
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Lin @ 2016-01-25 1:13 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson; +Cc: linux-mmc, linux-kernel, Shawn Lin
This patch remove repetitive clear interrupt while
probing dw_mmc.
Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---
drivers/mmc/host/dw_mmc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 7128351..1991872 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
* Enable interrupts for command done, data over, data empty,
* receive ready and error such as transmit, receive timeout, crc error
*/
- mci_writel(host, RINTSTS, 0xFFFFFFFF);
mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
SDMMC_INT_TXDR | SDMMC_INT_RXDR |
DW_MCI_ERROR_FLAGS);
--
2.3.7
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt
2016-01-25 1:13 [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin
@ 2016-01-25 4:14 ` Jaehoon Chung
2016-01-25 4:56 ` Shawn Lin
0 siblings, 1 reply; 5+ messages in thread
From: Jaehoon Chung @ 2016-01-25 4:14 UTC (permalink / raw)
To: Shawn Lin, Ulf Hansson; +Cc: linux-mmc, linux-kernel
Hi, Shawn.
On 01/25/2016 10:13 AM, Shawn Lin wrote:
> This patch remove repetitive clear interrupt while
> probing dw_mmc.
Could you explain to me more?
Best Regards,
Jaehoon Chung
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
>
> drivers/mmc/host/dw_mmc.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 7128351..1991872 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
> * Enable interrupts for command done, data over, data empty,
> * receive ready and error such as transmit, receive timeout, crc error
> */
> - mci_writel(host, RINTSTS, 0xFFFFFFFF);
> mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
> SDMMC_INT_TXDR | SDMMC_INT_RXDR |
> DW_MCI_ERROR_FLAGS);
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt
2016-01-25 4:14 ` Jaehoon Chung
@ 2016-01-25 4:56 ` Shawn Lin
2016-01-25 8:55 ` Arnd Bergmann
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Lin @ 2016-01-25 4:56 UTC (permalink / raw)
To: Jaehoon Chung, Ulf Hansson; +Cc: shawn.lin, linux-mmc, linux-kernel
On 2016/1/25 12:14, Jaehoon Chung wrote:
> Hi, Shawn.
>
> On 01/25/2016 10:13 AM, Shawn Lin wrote:
>> This patch remove repetitive clear interrupt while
>> probing dw_mmc.
>
> Could you explain to me more?
yes, it's a trivial improvement.
dw_mci_probe clear interrupt and disable all interrupt firstly.
Then commit 2da1d7f2 add a new clear-interrupt operation before
enable some interrupt. I can't see any reason to clear it twice
here. No any side effect I had found in my test pattern without this
. May I miss some important case?
>
> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>> drivers/mmc/host/dw_mmc.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 7128351..1991872 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
>> * Enable interrupts for command done, data over, data empty,
>> * receive ready and error such as transmit, receive timeout, crc error
>> */
>> - mci_writel(host, RINTSTS, 0xFFFFFFFF);
>> mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
>> SDMMC_INT_TXDR | SDMMC_INT_RXDR |
>> DW_MCI_ERROR_FLAGS);
>>
>
>
>
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt
2016-01-25 4:56 ` Shawn Lin
@ 2016-01-25 8:55 ` Arnd Bergmann
2016-01-26 0:40 ` Shawn Lin
0 siblings, 1 reply; 5+ messages in thread
From: Arnd Bergmann @ 2016-01-25 8:55 UTC (permalink / raw)
To: Shawn Lin; +Cc: Jaehoon Chung, Ulf Hansson, linux-mmc, linux-kernel
On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
> On 2016/1/25 12:14, Jaehoon Chung wrote:
> > Hi, Shawn.
> >
> > On 01/25/2016 10:13 AM, Shawn Lin wrote:
> >> This patch remove repetitive clear interrupt while
> >> probing dw_mmc.
> >
> > Could you explain to me more?
>
> yes, it's a trivial improvement.
>
> dw_mci_probe clear interrupt and disable all interrupt firstly.
> Then commit 2da1d7f2 add a new clear-interrupt operation before
> enable some interrupt. I can't see any reason to clear it twice
> here. No any side effect I had found in my test pattern without this
> . May I miss some important case?
>
The explanation should go into the patch description to explain why
it is done. The one sentence "This patch remove repetitive clear
interrupt while probing dw_mmc" that you wrote instead can be
removed, it just repeats the patch subject.
Arnd
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt
2016-01-25 8:55 ` Arnd Bergmann
@ 2016-01-26 0:40 ` Shawn Lin
0 siblings, 0 replies; 5+ messages in thread
From: Shawn Lin @ 2016-01-26 0:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: shawn.lin, Jaehoon Chung, Ulf Hansson, linux-mmc, linux-kernel
On 2016/1/25 16:55, Arnd Bergmann wrote:
> On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
>> On 2016/1/25 12:14, Jaehoon Chung wrote:
>>> Hi, Shawn.
>>>
>>> On 01/25/2016 10:13 AM, Shawn Lin wrote:
>>>> This patch remove repetitive clear interrupt while
>>>> probing dw_mmc.
>>>
>>> Could you explain to me more?
>>
>> yes, it's a trivial improvement.
>>
>> dw_mci_probe clear interrupt and disable all interrupt firstly.
>> Then commit 2da1d7f2 add a new clear-interrupt operation before
>> enable some interrupt. I can't see any reason to clear it twice
>> here. No any side effect I had found in my test pattern without this
>> . May I miss some important case?
>>
>
> The explanation should go into the patch description to explain why
> it is done. The one sentence "This patch remove repetitive clear
> interrupt while probing dw_mmc" that you wrote instead can be
> removed, it just repeats the patch subject.
>
Hi Arnd
Thanks for sharing that. I will respin v2 to add this into commit-msg.
> Arnd
>
>
>
--
Best Regards
Shawn Lin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-26 0:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-25 1:13 [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin
2016-01-25 4:14 ` Jaehoon Chung
2016-01-25 4:56 ` Shawn Lin
2016-01-25 8:55 ` Arnd Bergmann
2016-01-26 0:40 ` Shawn Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).