From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752314AbcAYFw0 (ORCPT ); Mon, 25 Jan 2016 00:52:26 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:4949 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbcAYFwY convert rfc822-to-8bit (ORCPT ); Mon, 25 Jan 2016 00:52:24 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Sun, 24 Jan 2016 21:53:20 -0800 Message-ID: <56A5B853.3070609@nvidia.com> Date: Mon, 25 Jan 2016 13:53:23 +0800 From: Wei Ni User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Thierry Reding CC: , , , , , , Subject: Re: [PATCH V3 07/11] of: Add bindings of hw-trips for soctherm References: <1453111448-12445-1-git-send-email-wni@nvidia.com> <20160121145251.GD32301@ulmo> In-Reply-To: <20160121145251.GD32301@ulmo> X-Originating-IP: [10.19.224.146] X-ClientProxiedBy: HKMAIL101.nvidia.com (10.18.16.10) To HKMAIL101.nvidia.com (10.18.16.10) Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年01月21日 22:52, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Jan 18, 2016 at 06:04:08PM +0800, Wei Ni wrote: >> Add hw-trips sub-node for soctherm, which is >> used to describe the hardware trip points for >> each soctherm sensors. > > Please make use of the full 78 characters in each line. Otherwise looks > good to me. Ok, I will check it again. > > Oh, also make sure to Cc: devicetree@vger.kernel.org on device tree > binding patches. Doing that now, hence quoting verbatim. Sure, will do it. > > Thierry > >> >> Signed-off-by: Wei Ni >> --- >> .../devicetree/bindings/thermal/tegra-soctherm.txt | 24 ++++++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt >> index 6b68cd150405..75dc9dbe7e1a 100644 >> --- a/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt >> +++ b/Documentation/devicetree/bindings/thermal/tegra-soctherm.txt >> @@ -26,6 +26,15 @@ Required properties : >> of this property. See for a >> list of valid values when referring to thermal sensors. >> >> +Optional properties: >> +- hw-trip-points : A sub-node which is a container of hardware trip points >> + for each sensors. >> + * sensors: Sub-nodes which are used to describe the HW trip points info, >> + must be named as "cpu", "gpu", "mem", "pll". >> + Properties: >> + - thermtrip-temperature : Shutdown or reset temperature in millicelsius, >> + once the temperature of this sensor is higher than the >> + thermtrip-temperature, the system will be shutdown or reset. >> >> Example : >> >> @@ -40,6 +49,21 @@ Example : >> reset-names = "soctherm"; >> >> #thermal-sensor-cells = <1>; >> + >> + hw-trip-points { >> + cpu { >> + thermtrip-temperature = <103000>; >> + }; >> + gpu { >> + thermtrip-temperature = <103500>; >> + }; >> + mem { >> + thermtrip-temperature = <103500>; >> + }; >> + pll { >> + thermtrip-temperature = <105000>; >> + }; >> + }; >> }; >> >> Example: referring to thermal sensors : >> -- >> 1.9.1 >> > > * Unknown Key > * 0x7F3EB3A1 >