From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755438AbcAYGYS (ORCPT ); Mon, 25 Jan 2016 01:24:18 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:39429 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752684AbcAYGYP convert rfc822-to-8bit (ORCPT ); Mon, 25 Jan 2016 01:24:15 -0500 X-AuditID: cbfee68d-f79646d000001355-14-56a5bf8d4d1e MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 8BIT Message-id: <56A5BF8D.8070807@samsung.com> Date: Mon, 25 Jan 2016 15:24:13 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Charles Keepax , mturquette@baylibre.com, lee.jones@linaro.org Cc: sboyd@codeaurora.org, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v3 1/4] extcon: arizona: Remove enable/disable of 32k clock References: <1452252582-20834-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> In-reply-to: <1452252582-20834-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCIsWRmVeSWpSXmKPExsWyRsSkSLd3/9Iwg+XnjCz+TbnBbjH/yDlW i/tfjzJafOy5x2pxedccNouLp1wtbjeuYLNY/vY/m8WPM90sDpwe72+0sntc7utl8rhzbQ+b x8uJv9k8+rasYvT4vEkugC2KyyYlNSezLLVI3y6BK2PH15SCTTwVW18/Ym1gnM7VxcjJISFg ItHacoEJwhaTuHBvPRuILSSwglHi9YR0mJo3LYuA4lxA8VmMEkcubwFr4BUQlPgx+R4LiM0s oC4xad4i5i5GDiBbRGL1mnqIsLbEsoWvmSF6HzBKrFz1lBWiV0tizdw17CD1LAKqEgfvuIKE 2YDC+1/cYAMJiwpESHSfqAQJiwhkSiw+0wt2ArPABkaJnQc7mEBqhAX8JT5OC4Y4OVTi2Y17 YNM5BcIkPr89wgpSLyHwll1iza7P7CAJFgEBiW+TD7GA9EoIyEpsOsAM8aKkxMEVN1gmMIrP QvLYLCSPzUJ4bBaSxxYwsqxiFE0tSC4oTkovMtQrTswtLs1L10vOz93ECIzc0/+e9e5gvH3A +hCjAAejEg+vhdrSMCHWxLLiytxDjKZAB01klhJNzgemh7ySeENjMyMLUxNTYyNzSzMlcV5F qZ/BQgLpiSWp2ampBalF8UWlOanFhxiZODilGhhvR3XlLu1/x/NOIPjwW55dn41DLu922jvx r93GVUtN7l9JUQnSc3wYvVo/oODrhi2dEaFnHv8S3fH9jdehUyeXaenacuntdaxf2NrzVDZg Z/KRExWnWKtlvt6rZnvis+s5j9FMs381LrWrPd+VHgi8F2qQ/eZu6F0z7Zknnl0Ru2R+XSrr w5JzSizFGYmGWsxFxYkADxXoCNcCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrNIsWRmVeSWpSXmKPExsVy+t9jQd3e/UvDDE516Fr8m3KD3WL+kXOs Fve/HmW0+Nhzj9Xi8q45bBYXT7la3G5cwWax/O1/NosfZ7pZHDg93t9oZfe43NfL5HHn2h42 j5cTf7N59G1ZxejxeZNcAFtUA6NNRmpiSmqRQmpecn5KZl66rZJ3cLxzvKmZgaGuoaWFuZJC XmJuqq2Si0+ArltmDtBVSgpliTmlQKGAxOJiJX07TBNCQ9x0LWAaI3R9Q4LgeowM0EDCGsaM 57e/MBYs4Km4frKZuYGxlauLkZNDQsBE4k3LIjYIW0ziwr31QDYXh5DALEaJI5e3MIEkeAUE JX5MvsfSxcjBwSwgL3HkUjZImFlAXWLSvEXMEPUPGCVWrnrKClGvJbFm7hp2kHoWAVWJg3dc QcJsQOH9L26wgYRFBSIkuk9UgoRFBDIlFp/pBVvLLLCBUWLnwQ4mkBphAX+Jj9OCQWqEBEIl nt24BzadUyBM4vPbI6wTGIFuRDhuFsJxs5Act4CReRWjRGpBckFxUnquUV5quV5xYm5xaV66 XnJ+7iZGcMQ/k97BeHiX+yFGAQ5GJR5eC7WlYUKsiWXFlbmHGCU4mJVEeNV3A4V4UxIrq1KL 8uOLSnNSiw8xmgJ9N5FZSjQ5H5iM8kriDY1NzIwsjcwNLYyMzZXEefddigwTEkhPLEnNTk0t SC2C6WPi4JRqYNQy56hZu3/mLftdV839YtfeDawslTqe+PLdw+a3rOvjSxlaIs5FmxxKZoix Yr30U5JnYa881+oTQWFeddGxVfIJsy+r8V/wsmUz+XxW/63r/NIFxhdmHj55/dZ1Dx+JIqbe I1tOHGWfsrf1j5xC544dq3h85ztNfbex/OnvLbsNpj4K7RQJUFBiKc5INNRiLipOBAB2lef1 DgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 01월 08일 20:29, Charles Keepax wrote: > The 32k clock is unconditionally enabled by the MFD core so there is no > need to control it from the extcon device, so this patch removes the > control of the 32k clock. > > Signed-off-by: Charles Keepax > --- > > No changes since v2. > > Thanks, > Charles > > drivers/extcon/extcon-arizona.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index e4890dd..52d041f 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -1571,7 +1571,6 @@ static int arizona_extcon_probe(struct platform_device *pdev) > goto err_micdet; > } > > - arizona_clk32k_enable(arizona); > regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_DEBOUNCE, > ARIZONA_JD1_DB, ARIZONA_JD1_DB); > regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE, > @@ -1642,7 +1641,6 @@ static int arizona_extcon_remove(struct platform_device *pdev) > cancel_delayed_work_sync(&info->hpdet_work); > regmap_update_bits(arizona->regmap, ARIZONA_JACK_DETECT_ANALOGUE, > ARIZONA_JD1_ENA, 0); > - arizona_clk32k_disable(arizona); > > return 0; > } > Acked-by: Chanwoo Choi If I apply only this patch on extcon tree, the kernel build error will happen on other tree. I think that this patch will go on clk tree and then send pull request of immutable branch. Thanks, Chanwoo Choi