From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755992AbcAYJNk (ORCPT ); Mon, 25 Jan 2016 04:13:40 -0500 Received: from e28smtp04.in.ibm.com ([125.16.236.4]:46620 "EHLO e28smtp04.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752521AbcAYJMz (ORCPT ); Mon, 25 Jan 2016 04:12:55 -0500 X-IBM-Helo: d28relay03.in.ibm.com X-IBM-MailFrom: khandual@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Message-ID: <56A5E709.2070908@linux.vnet.ibm.com> Date: Mon, 25 Jan 2016 14:42:41 +0530 From: Anshuman Khandual User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Madhavan Srinivasan , mpe@ellerman.id.au CC: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/perf: Remove PPMU_HAS_SSLOT flag for Power8 References: <1453710826-3160-1-git-send-email-maddy@linux.vnet.ibm.com> In-Reply-To: <1453710826-3160-1-git-send-email-maddy@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable x-cbid: 16012509-0013-0000-0000-000009C9336A Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2016 02:03 PM, Madhavan Srinivasan wrote: > Commit: 7a7868326d77 introduced PPMU_HAS_SSLOT flag to > remove assumption of MMCRA[SLOT] with respect to > PPMU_ALT_SIPR flag. Commit 7a7868326d77's message also > specifies that Power8 does not support MMCRA[SLOT]. > But still PPMU_HAS_SSLOT flag managed to get into > Power8 code. Patch to remove the same from Power8 flags. Please follow the present protocol of referring to a commit ID like this (: ""). Also this PMU flag was added originally through the base POWER8 PMU enablement commit (e05b9b9e5c1: "powerpc/perf: Power8 PMU support") which can be mentioned in the "Fixes:" part.