From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756069AbcAZAlH (ORCPT ); Mon, 25 Jan 2016 19:41:07 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:48131 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752280AbcAZAlG (ORCPT ); Mon, 25 Jan 2016 19:41:06 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt To: Arnd Bergmann References: <1453684420-1860-1-git-send-email-shawn.lin@rock-chips.com> <56A5A11A.5030103@samsung.com> <56A5AAF9.5090002@rock-chips.com> <1630713.rPyRx6D05H@wuerfel> Cc: shawn.lin@rock-chips.com, Jaehoon Chung , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org From: Shawn Lin Message-ID: <56A6C088.8060103@rock-chips.com> Date: Tue, 26 Jan 2016 08:40:40 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1630713.rPyRx6D05H@wuerfel> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/25 16:55, Arnd Bergmann wrote: > On Monday 25 January 2016 12:56:25 Shawn Lin wrote: >> On 2016/1/25 12:14, Jaehoon Chung wrote: >>> Hi, Shawn. >>> >>> On 01/25/2016 10:13 AM, Shawn Lin wrote: >>>> This patch remove repetitive clear interrupt while >>>> probing dw_mmc. >>> >>> Could you explain to me more? >> >> yes, it's a trivial improvement. >> >> dw_mci_probe clear interrupt and disable all interrupt firstly. >> Then commit 2da1d7f2 add a new clear-interrupt operation before >> enable some interrupt. I can't see any reason to clear it twice >> here. No any side effect I had found in my test pattern without this >> . May I miss some important case? >> > > The explanation should go into the patch description to explain why > it is done. The one sentence "This patch remove repetitive clear > interrupt while probing dw_mmc" that you wrote instead can be > removed, it just repeats the patch subject. > Hi Arnd Thanks for sharing that. I will respin v2 to add this into commit-msg. > Arnd > > > -- Best Regards Shawn Lin