From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756318AbcAZCXz (ORCPT ); Mon, 25 Jan 2016 21:23:55 -0500 Received: from lucky1.263xmail.com ([211.157.147.132]:53408 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752128AbcAZCXx (ORCPT ); Mon, 25 Jan 2016 21:23:53 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: shawn.lin@rock-chips.com X-FST-TO: wxt@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: shawn.lin@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH] arm: dts: rockchip: remove broken-cd from emmc and sdio To: Heiko Stuebner References: <1453774003-10184-1-git-send-email-shawn.lin@rock-chips.com> Cc: shawn.lin@rock-chips.com, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, zhengxing@rock-chips.com, wxt@rock-chips.com From: Shawn Lin Message-ID: <56A6D89F.9020602@rock-chips.com> Date: Tue, 26 Jan 2016 10:23:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453774003-10184-1-git-send-email-shawn.lin@rock-chips.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Xing and Caesar Hi Xing and Caesar, For future dts, we should avoid to add these two properties together. :) On 2016/1/26 10:06, Shawn Lin wrote: > Only one of "broken-cd" and "non-removable" should be supplied > according to Documentation/devicetree/bindings/mmc/mmc.txt. > Obviously emmc and sdio-wifi are non-removable devices, while > broken-cd is for removable device whose card detect pin is broken. > > Signed-off-by: Shawn Lin > --- > > arch/arm/boot/dts/rk3036-kylin.dts | 1 - > arch/arm/boot/dts/rk3036.dtsi | 1 - > arch/arm/boot/dts/rk3066a-rayeager.dts | 2 -- > arch/arm/boot/dts/rk3228-evb.dts | 1 - > arch/arm/boot/dts/rk3288-evb.dtsi | 1 - > arch/arm/boot/dts/rk3288-firefly.dtsi | 2 -- > arch/arm/boot/dts/rk3288-popmetal.dts | 1 - > arch/arm/boot/dts/rk3288-veyron.dtsi | 2 -- > 8 files changed, 11 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3036-kylin.dts b/arch/arm/boot/dts/rk3036-kylin.dts > index 992f9ca..023153a 100644 > --- a/arch/arm/boot/dts/rk3036-kylin.dts > +++ b/arch/arm/boot/dts/rk3036-kylin.dts > @@ -262,7 +262,6 @@ > &sdio { > status = "okay"; > > - broken-cd; > bus-width = <4>; > cap-sdio-irq; > default-sample-phase = <90>; > diff --git a/arch/arm/boot/dts/rk3036.dtsi b/arch/arm/boot/dts/rk3036.dtsi > index b9567c1..cf54066 100644 > --- a/arch/arm/boot/dts/rk3036.dtsi > +++ b/arch/arm/boot/dts/rk3036.dtsi > @@ -214,7 +214,6 @@ > compatible = "rockchip,rk3288-dw-mshc"; > reg = <0x1021c000 0x4000>; > interrupts = ; > - broken-cd; > bus-width = <8>; > cap-mmc-highspeed; > clock-frequency = <37500000>; > diff --git a/arch/arm/boot/dts/rk3066a-rayeager.dts b/arch/arm/boot/dts/rk3066a-rayeager.dts > index 341c1f8..e9db017 100644 > --- a/arch/arm/boot/dts/rk3066a-rayeager.dts > +++ b/arch/arm/boot/dts/rk3066a-rayeager.dts > @@ -170,7 +170,6 @@ > }; > > &emmc { > - broken-cd; > bus-width = <8>; > cap-mmc-highspeed; > disable-wp; > @@ -336,7 +335,6 @@ > }; > > &mmc1 { > - broken-cd; > bus-width = <4>; > disable-wp; > non-removable; > diff --git a/arch/arm/boot/dts/rk3228-evb.dts b/arch/arm/boot/dts/rk3228-evb.dts > index e3898b8..a6d6a7b 100644 > --- a/arch/arm/boot/dts/rk3228-evb.dts > +++ b/arch/arm/boot/dts/rk3228-evb.dts > @@ -53,7 +53,6 @@ > }; > > &emmc { > - broken-cd; > cap-mmc-highspeed; > mmc-ddr-1_8v; > disable-wp; > diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi b/arch/arm/boot/dts/rk3288-evb.dtsi > index 4faabdb..f90e408 100644 > --- a/arch/arm/boot/dts/rk3288-evb.dtsi > +++ b/arch/arm/boot/dts/rk3288-evb.dtsi > @@ -172,7 +172,6 @@ > }; > > &emmc { > - broken-cd; > bus-width = <8>; > cap-mmc-highspeed; > disable-wp; > diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi > index 4e3fd9a..3f36af7 100644 > --- a/arch/arm/boot/dts/rk3288-firefly.dtsi > +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi > @@ -208,7 +208,6 @@ > }; > > &emmc { > - broken-cd; > bus-width = <8>; > cap-mmc-highspeed; > disable-wp; > @@ -485,7 +484,6 @@ > }; > > &sdio0 { > - broken-cd; > bus-width = <4>; > disable-wp; > non-removable; > diff --git a/arch/arm/boot/dts/rk3288-popmetal.dts b/arch/arm/boot/dts/rk3288-popmetal.dts > index 65c4756..cc2be77 100644 > --- a/arch/arm/boot/dts/rk3288-popmetal.dts > +++ b/arch/arm/boot/dts/rk3288-popmetal.dts > @@ -162,7 +162,6 @@ > }; > > &emmc { > - broken-cd; > bus-width = <8>; > cap-mmc-highspeed; > disable-wp; > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > index 9fce91f..725e08b 100644 > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > @@ -146,7 +146,6 @@ > &emmc { > status = "okay"; > > - broken-cd; > bus-width = <8>; > cap-mmc-highspeed; > rockchip,default-sample-phase = <158>; > @@ -352,7 +351,6 @@ > &sdio0 { > status = "okay"; > > - broken-cd; > bus-width = <4>; > cap-sd-highspeed; > cap-sdio-irq; > -- Best Regards Shawn Lin