From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756202AbcAZEzZ (ORCPT ); Mon, 25 Jan 2016 23:55:25 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:36139 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753412AbcAZEzR (ORCPT ); Mon, 25 Jan 2016 23:55:17 -0500 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfee68f-f793a6d000001364-99-56a6fc3302d6 Content-transfer-encoding: 8BIT Message-id: <56A6FC32.9000801@samsung.com> Date: Tue, 26 Jan 2016 13:55:14 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Krzysztof Kozlowski , Arnd Bergmann Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH] drm/exynos: fix building without CONFIG_PM_SLEEP References: <9569056.LBRz4v8fSj@wuerfel> In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkSNf4z7Iwg7avbBZ/Jx1jt7jy9T2b xYt7F1ksXr8wtDjb9IbdYtPja6wWl3fNYbOYcX4fk8WMyS/ZHDg9fv+axOhxv/s4k8fmJfUe fVtWMXp83iQXwBrFZZOSmpNZllqkb5fAlXHk3UTmgj8iFZcePWBuYOwW7GLk5JAQMJF4N+EG O4QtJnHh3nq2LkYuDiGBFYwSO768Z+li5AArevrWASK+lFFi7frXbCANvAKCEj8m3wOrYRaQ lzhyKRvCVJeYMiUXovwBo8Td6SBjQMq1JA6s6WECsVkEVCWOL7nMCmKzAdkTV9xnA+kVFYiQ 6D5RCWKKCARIHP0ZCDKGWaCfSeLujPlgW4UFXCW29y4EaxUSyJd49nEymM0pECzx6vBRZpAG CYF77BKvPy1ghtglIPFt8iGoV2QlNh1ghnhXUuLgihssExjFZiF5ZhbCM7MQnlnAyLyKUTS1 ILmgOCm9yFivODG3uDQvXS85P3cTIzD6Tv971r+D8e4B60OMAhyMSjy8GwqWhQmxJpYVV+Ye YjQFumEis5Rocj4wxvNK4g2NzYwsTE1MjY3MLc2UxHkXSv0MFhJITyxJzU5NLUgtii8qzUkt PsTIxMEp1cA4ubOkM6RBzb/27sR+rrh7sW8tuZq/vM8vjOVWMqh1CVnyaHbacr7ts50e+Dxe LW1wrcs0h9OW8fT2Y9UrRF5Pb9/8cLHvWpPfcf18T1+bXMiN8DHu3KH8snaJZcaSkICGbiFt T+HVVyfGpTptfhD64Nu+UzbTHY6c/pvD1L9HgG3bpBV3ujcosRRnJBpqMRcVJwIAGLW4h7kC AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jAV3jP8vCDF5OZbT4O+kYu8WVr+/Z LF7cu8hi8fqFocXZpjfsFpseX2O1uLxrDpvFjPP7mCxmTH7J5sDp8fvXJEaP+93HmTw2L6n3 6NuyitHj8ya5ANaoBkabjNTElNQihdS85PyUzLx0WyXv4HjneFMzA0NdQ0sLcyWFvMTcVFsl F58AXbfMHKB7lBTKEnNKgUIBicXFSvp2mCaEhrjpWsA0Ruj6hgTB9RgZoIGENYwZR95NZC74 I1Jx6dED5gbGbsEuRg4OCQETiadvHboYOYFMMYkL99azdTFycQgJLGWUWLv+NRtIgldAUOLH 5HssIPXMAvISRy5lQ5jqElOm5EKUP2CUuDv9PQtEuZbEgTU9TCA2i4CqxPEll1lBbDYge+KK +2wgvaICERLdJypBTBGBAImjPwNBxjAL9DNJ3J0xH2yrsICrxPbehWCtQgL5Es8+TgazOQWC JV4dPso8gVFgFpLjZiEcNwvhuAWMzKsYJVILkguKk9JzjfJSy/WKE3OLS/PS9ZLzczcxgiP8 mfQOxsO73A8xCnAwKvHwbihYFibEmlhWXJl7iFGCg1lJhHfSR6AQb0piZVVqUX58UWlOavEh RlOg7yYyS4km5wOTT15JvKGxiZmRpZG5oYWRsbmSOO++S5FhQgLpiSWp2ampBalFMH1MHJxS DYzswjdLN8wvC39i+uXJoen+TqHcwlNXMX8OuLQnM/9qt0ZZTqi60YKnETN33JzPsyk2wKaC 2au+mu3/tom+H+smzmBlfbZNSiYzS2/mmd1TZLPFPNd2pv56oNrbKrvY4YtltOm1k/9mb7J8 faT7xqurUs/s88JMyt5//fbNPyR+icRX7ysqJQ1KLMUZiYZazEXFiQC9Ju0TBgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016년 01월 26일 08:40에 Krzysztof Kozlowski 이(가) 쓴 글: > 2015-11-18 0:08 GMT+09:00 Arnd Bergmann : >> The runtime PM operations use the suspend/resume functions >> even when CONFIG_PM_SLEEP is not set, but this now fails >> for the exynos DRM driver: >> >> exynos_mixer.c:1289:61: error: 'exynos_mixer_resume' undeclared here (not in a function) >> SET_RUNTIME_PM_OPS(exynos_mixer_suspend, exynos_mixer_resume, NULL) >> >> This removes the #ifdef and instead marks the functions as >> __maybe_unused, which does the right thing in all cases and >> also looks nicer. >> >> Signed-off-by: Arnd Bergmann >> Fixes: ("drm/exynos: add pm_runtime to Mixer") > > Dear Inki, > > Ping? On 4.5-rc1 this is still broken. Can you apply this for fixes > for current rc-cycle? Got it. Thanks, Inki Dae > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > > >> >> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c >> index 7498c6e76a53..fcaf71df77c1 100644 >> --- a/drivers/gpu/drm/exynos/exynos_mixer.c >> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c >> @@ -1230,8 +1230,7 @@ static int mixer_remove(struct platform_device *pdev) >> return 0; >> } >> >> -#ifdef CONFIG_PM_SLEEP >> -static int exynos_mixer_suspend(struct device *dev) >> +static int __maybe_unused exynos_mixer_suspend(struct device *dev) >> { >> struct mixer_context *ctx = dev_get_drvdata(dev); >> struct mixer_resources *res = &ctx->mixer_res; >> @@ -1247,7 +1246,7 @@ static int exynos_mixer_suspend(struct device *dev) >> return 0; >> } >> >> -static int exynos_mixer_resume(struct device *dev) >> +static int __maybe_unused exynos_mixer_resume(struct device *dev) >> { >> struct mixer_context *ctx = dev_get_drvdata(dev); >> struct mixer_resources *res = &ctx->mixer_res; >> @@ -1283,7 +1282,6 @@ static int exynos_mixer_resume(struct device *dev) >> >> return 0; >> } >> -#endif >> >> static const struct dev_pm_ops exynos_mixer_pm_ops = { >> SET_RUNTIME_PM_OPS(exynos_mixer_suspend, exynos_mixer_resume, NULL) >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >