From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755639AbcAZG12 (ORCPT ); Tue, 26 Jan 2016 01:27:28 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:63340 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754305AbcAZG1X (ORCPT ); Tue, 26 Jan 2016 01:27:23 -0500 Subject: Re: [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC To: Lee Jones References: <1452514817-118311-1-git-send-email-puck.chen@hisilicon.com> <1452514817-118311-2-git-send-email-puck.chen@hisilicon.com> <20160125125356.GO3368@x1> CC: , , , , , , , , , , , , , , , , From: chenfeng Message-ID: <56A711AB.10604@hisilicon.com> Date: Tue, 26 Jan 2016 14:26:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <20160125125356.GO3368@x1> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.192.172] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020201.56A711C1.00D8,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ebfa460755a556f31dd49efc63933ac2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/25 20:53, Lee Jones wrote: > On Mon, 11 Jan 2016, Chen Feng wrote: > >> Add document for mfd driver hi655x pmic driver >> >> Signed-off-by: Chen Feng >> Signed-off-by: Fei Wang >> Signed-off-by: Xinwei Kong >> --- >> .../devicetree/bindings/mfd/hisilicon,hi655x.txt | 28 ++++++++++++++++++++++ >> 1 file changed, 28 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt >> >> diff --git a/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt >> new file mode 100644 >> index 0000000..3180c40 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/mfd/hisilicon,hi655x.txt >> @@ -0,0 +1,28 @@ >> +Hisilicon hi655x Power Management Integrated Circuit (PMIC) >> + >> +The hardware layout for access PMIC Hi655x from AP SoC Hi6220. >> +Between PMIC Hi655x and Hi6220, the physical signal channel is SSI. >> +We can use memory-mapped I/O to communicate. >> + >> ++----------------+ +-------------+ >> +| | | | >> +| Hi6220 | SSI bus | Hi655x | >> +| |-------------| | >> +| |(REGMAP_MMIO)| | >> ++----------------+ +-------------+ >> + >> +Required properties: >> +- compatible: Should be "hisilicon,hi655x-pmic" >> +- reg: Base address of PMIC on hi6220 soc > > SoC > >> +- interrupt-controller: Hi655x has internal IRQs (has own IRQ domain). >> +- pmic-gpios: The gpio used by pmic irq. > > PMIC IRQ > >> + >> +Example: >> + pmic: pmic@f8000000 { >> + compatible = "hisilicon,hi655x-pmic"; >> + reg = <0x0 0xf8000000 0x0 0x1000>; >> + #interrupt-cells = <2>; >> + interrupt-controller; >> + pmic-gpios = <&gpio1 2 0>; > > What's the last cell for here? If they are flags, there is probably a > #define you can use in dt-include. ok, I will use the irq flag in dt-include. > >> + status = "disabled"; > > What's the point in disabling example code? It's just copy from the dts, I will drop this. > >> + } >