From: "Matias Bjørling" <m@bjorling.me>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Keith Busch <keith.busch@intel.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] nvme: lightnvm: buffer overflow in nvme_nvm_identity()
Date: Tue, 26 Jan 2016 10:56:57 +0100 [thread overview]
Message-ID: <56A742E9.3040108@bjorling.me> (raw)
In-Reply-To: <20160126092734.GE15717@mwanda>
On 01/26/2016 10:27 AM, Dan Carpenter wrote:
> nvme_nvm_id->ppaf is 4 bytes larger than nvm_id->ppaf. We're using the
> larger size struct for the sizeof() so we end up corrupting the
> first four bytes of nvm_id->groups[]. It doesn't look like we actually
> want to copy those last bytes anyway.
>
Thanks, Dan. You are right. The four bytes are overwritten afterwards
and hid the issue.
prev parent reply other threads:[~2016-01-26 9:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 9:27 [patch] nvme: lightnvm: buffer overflow in nvme_nvm_identity() Dan Carpenter
2016-01-26 9:56 ` Matias Bjørling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A742E9.3040108@bjorling.me \
--to=m@bjorling.me \
--cc=axboe@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=keith.busch@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox