From: Lu Baolu <baolu.lu@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 03/12] usb: dbc: probe and setup xhci debug capability
Date: Tue, 26 Jan 2016 18:27:47 +0800 [thread overview]
Message-ID: <56A74A23.2010108@linux.intel.com> (raw)
In-Reply-To: <20160126073653.GB24272@kroah.com>
On 01/26/2016 03:36 PM, Greg Kroah-Hartman wrote:
> On Tue, Jan 26, 2016 at 12:14:16PM +0800, Lu Baolu wrote:
>> xHCI debug capability (DbC) is an optional functionality provided
>> by an xHCI host controller. Software learns this capability by
>> walking through the extended capability list in mmio of the host.
>>
>> This patch introduces the code to probe and initialize the debug
>> capability hardware during early boot. With hardware initialization
>> done, the debug target (system under debug which has DbC enabled)
>> will present a debug device through the debug port. The debug device
>> is fully compliant with the USB framework and provides the equivalent
>> of a very high performance (USB3) full-duplex serial link between the
>> debug host and target.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> ---
>> MAINTAINERS | 7 +
>> arch/x86/Kconfig.debug | 12 +
>> drivers/usb/early/Makefile | 1 +
> Why did you make a whole new subdirectory, just for your one driver?
> Please don't do that, just put it in the host controller directory where
> it belongs...
I am sorry, but driver/usb/early is an existing subdirectory.
$ ls drivers/usb/early/
ehci-dbgp.c Makefile
If I understand it correctly, the "early" subdirectory is used to
keep drivers which should be loaded during early boot stage.
We already have code for EHCI debug port there with the
filename ehci-dbgp.c. It is used to aid the developer to get
kernel messages during early boot through EHCI debug port.
What I have done is to implement the same thing with
xHCI debug port. It's not part of xHCI host controller driver
and it is executed even before xHCI driver is loaded.
Thanks,
Baolu
>
>
next prev parent reply other threads:[~2016-01-26 10:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-26 4:14 [PATCH v6 00/12] usb: early: add support for early printk through USB3 debug port Lu Baolu
2016-01-26 4:14 ` [PATCH v6 01/12] usb: xhci: add sysfs file for xHCI " Lu Baolu
2016-01-26 4:14 ` [PATCH v6 02/12] x86: fixmap: add permanent fixmap for xhci " Lu Baolu
2016-01-26 4:14 ` [PATCH v6 03/12] usb: dbc: probe and setup xhci debug capability Lu Baolu
2016-01-26 7:36 ` Greg Kroah-Hartman
2016-01-26 10:27 ` Lu Baolu [this message]
2016-02-03 21:42 ` Greg Kroah-Hartman
2016-01-26 4:14 ` [PATCH v6 04/12] usb: dbc: add support for Intel xHCI dbc quirk Lu Baolu
2016-01-26 4:14 ` [PATCH v6 05/12] usb: dbc: add debug buffer Lu Baolu
2016-01-26 4:14 ` [PATCH v6 06/12] usb: dbc: add bulk out and bulk in interfaces Lu Baolu
2016-01-26 4:14 ` [PATCH v6 07/12] usb: dbc: handle dbc-configured exit Lu Baolu
2016-01-26 4:14 ` [PATCH v6 08/12] usb: dbc: handle endpoint stall Lu Baolu
2016-01-26 4:14 ` [PATCH v6 09/12] x86: early_printk: add USB3 debug port earlyprintk support Lu Baolu
2016-01-26 6:44 ` kbuild test robot
2016-01-26 4:14 ` [PATCH v6 10/12] usb: dbc: add handshake between debug target and host Lu Baolu
2016-01-26 4:14 ` [PATCH v6 11/12] usb: serial: usb_debug: add support for dbc debug device Lu Baolu
2016-01-26 4:14 ` [PATCH v6 12/12] usb: doc: add document for xHCI DbC driver Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A74A23.2010108@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).