From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934462AbcAZM0Z (ORCPT ); Tue, 26 Jan 2016 07:26:25 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:56123 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933622AbcAZM0X (ORCPT ); Tue, 26 Jan 2016 07:26:23 -0500 Message-ID: <56A765DE.7040408@huawei.com> Date: Tue, 26 Jan 2016 20:26:06 +0800 From: Shannon Zhao User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Stefano Stabellini CC: , , , , , , , , , , , , , , Subject: Re: [PATCH v3 14/17] XEN: EFI: Move x86 specific codes to architecture directory References: <1453519184-11908-1-git-send-email-zhaoshenglong@huawei.com> <1453519184-11908-15-git-send-email-zhaoshenglong@huawei.com> <56A72B4F.2040909@huawei.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.16.142] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A090203.56A765E7.0125,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: ea8b69c38eaa720a611062453a52b3e8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/26 19:31, Stefano Stabellini wrote: > On Tue, 26 Jan 2016, Shannon Zhao wrote: >> > On 2016/1/26 0:44, Stefano Stabellini wrote: >>> > > On Sat, 23 Jan 2016, Shannon Zhao wrote: >>>>> > >> > From: Shannon Zhao >>>>> > >> > >>>>> > >> > Move x86 specific codes to architecture directory and export those EFI >>>>> > >> > runtime service functions. This will be useful for initializing runtime >>>>> > >> > service on ARM later. >>>>> > >> > >>>>> > >> > Signed-off-by: Shannon Zhao >>> > > This patch causes a build breakage on x86: >>> > > >>> > > arch/x86/xen/efi.c: In function ‘xen_efi_probe’: >>> > > arch/x86/xen/efi.c:101:2: error: implicit declaration of function ‘HYPERVISOR_platform_op’ [-Werror=implicit-function-declaration] >>> > > >> > This patch is based on following patch [1]. Maybe you need to update >> > your branch. :) >> > >> > [1] xen: rename dom0_op to platform_op >> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=cfafae940381207d48b11a73a211142dba5947d3 > Sorry, I made a mistake rebasing the series. It doesn't help that I > couldn't find any Linux RCs on top of which it applies cleanly. As Linus > tags RCs often enough, it is usually helpful to base one's work on a tag > so that it is easier for other people to work on it. > Ah, I'll rebase this series on top of the newest master at next version since the relevant patches are in master. > Please add my Reviewed-by to this patch. Thanks a lot! -- Shannon