linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Andy Lutomirski <luto@kernel.org>,
	OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	brijeshkumar.singh@amd.com, Jean Delvare <jdelvare@suse.de>
Subject: Re: ipmi_si feature request: SMBIOS-based autoloading
Date: Tue, 26 Jan 2016 07:32:42 -0600	[thread overview]
Message-ID: <56A7757A.6040704@acm.org> (raw)
In-Reply-To: <CALCETrXE+BapduFfKiiSujccaffdg8vEtvHw-mL0yV4nxNDNBA@mail.gmail.com>

On 01/24/2016 07:45 PM, Andy Lutomirski wrote:
> ipmi_si doesn't autoload on systems where it's found via SMBIOS.
> Could that be fixed?

I'm not really sure.  I kind of assumed this was handled in userland
like the ACPI tables.  I don't think there are many systems that have
SMBIOS and not ACPI, so I'm not sure of the impact here or what
to do.

> If I were doing it, I'd suggest rigging up some code that's compiled
> in to the main kernel even if ipmi_si is a module that creates the
> platform device if the dmi device is there and then set up a modalias
> so that the platofrm device causes ipmi_si to load.
>
> (In general, having the same driver create the platform device and
> register the platform driver means that autoloading is unlikely to
> work right.  See arch/x86/kernel/pmem.c for an example of a weird
> legacy device that gets this right.)

This sounds like kind of a hack.

> Alternatively, maybe /sys/firmware/dmi could learn how to advertise
> modaliases.  But that might be a giant mess to solve a tiny problem.

This sounds like the right way, but you are probably right.  Are
there any other resources that could benefit from this?  I"m
guessing not.

There is already a "dmi_save_ipmi_device" function that gets called
when scanning the SMBIOS table (see drivers/firmware/dmi_scan.c).
Maybe a tie-in there?  That happens pretty early, though, I'm not
sure if it's too early.

Of course it would be easy to have a file like pmem.c that detects
if an IPMI device is in the SMBIOS table and create a platform
device for it.

Are you willing to do this work?

-corey

  reply	other threads:[~2016-01-26 14:33 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25  1:45 ipmi_si feature request: SMBIOS-based autoloading Andy Lutomirski
2016-01-26 13:32 ` Corey Minyard [this message]
2016-01-26 13:43   ` [Openipmi-developer] " Corey Minyard
2016-01-26 17:29     ` Andy Lutomirski
2016-01-29 20:12       ` Corey Minyard
2016-02-01  8:46       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A7757A.6040704@acm.org \
    --to=minyard@acm.org \
    --cc=brijeshkumar.singh@amd.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).